Vnext-81889 | | Name fields for in-person Pickup

[pagrawal1-godaddy]

Summary

https://godaddy-corp.atlassian.net/browse/VNEXT-81889

Bruce in-person pickup checkout collected email but not customer first/last name, so completed orders often had blank names on order.billing. That broke merchant-facing Customer Info, C1, and new-order notifications.

This change:

• Adds required first/last name fields in the Pickup section (AddressForm with onlyNames)
• Persists those names on order.billing for all pickup payment paths (card, ACH, offline, free, express)
• Validates pickup names before complete / express wallet
• Hides duplicate name fields in Payment billing when pickup already collected names (hideNames on PaymentForm, CreditCard, and ACH) while still collecting billing address when required
• Free pickup shows names only in Pickup (submit button only in payment)

Package: @godaddy/react

Changeset

• Changeset added (docs)
  Added .changeset/pickup-customer-names.md — patch for @godaddy/react:
  Require customer first and last name for in-person pickup orders. Names are collected in the Pickup section, synced to order billing, and validated for card, offline, free, and express checkout paths.

Test Plan

Unit tests

• Address preserve: syncs only billing names in onlyNames mode without clearing billing address
• Single name field: keeps a single set of name fields for paid pickup with credit-card billing
• Immediate submit: persists pickup billing names before free-order confirmation without waiting for debounce
• Pickup name field rendering / validation coverage in checkout pickup + form-validation tests
• Focused suite green (checkout-address, checkout-draft-order-sync, checkout-form-validation, checkout-free-payment-form, checkout-pickup, sync-pickup-billing-names)

Manual / consumer checks (bruce-storefront after package publish)

• Free pickup — enter first/last name in Pickup, click Complete immediately → order has billing names
• Paid card pickup — names required in Pickup; Payment shows billing address only (no duplicate name fields); names + address both on order
• Paid ACH pickup — same as card: single name set in Pickup, address in Payment
• Offline pickup — names required and persisted on billing
• Paid pickup address preserve — fill billing address, then edit Pickup names → draft/order still keeps billing address
• Merchant order details / notifications show customer name (billing) for pickup orders

[changeset-bot]

🦋 Changeset detected

Latest commit: 813c2b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@godaddy/react	Patch
nextjs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[wcole1-godaddy]

Requesting changes for three reproduced pickup regressions and failing local quality gates.

• Editing required pickup names can clear an existing paid-order billing address.
• Immediate confirmation can occur before the debounced name update reaches the draft order.
• Paid card/ACH pickup renders duplicate billing-name controls.
• The package typecheck fails, and biome check ./src reports six errors in changed files.

The existing 447 React tests and GitHub CICD/CodeQL checks pass, so please add regressions for address preservation, a single rendered name field, and immediate-submit persistence. Since this is an OSS package, please also complete the PR Summary and Test Plan with consumer-facing context.

[pagrawal1-godaddy]

Hi Wes
I have fixed/Updated as you suggested
Regressions

1. Billing address cleared on name edit — onlyNames sync in AddressForm now sends only firstName/lastName and omits address (no more address: null).
2. Immediate confirm before debounced name sync — useFlushCheckoutSync enqueues current pickup billing names before draining; express paths call useSyncPickupBillingNames() before the wallet opens.
3. Duplicate name fields on card/ACH — same hideNames={isPickup && isBillingAddressRequired} applied in CreditCardContainer and GoDaddyACHForm, not only PaymentForm.

Regressions / tests added

• Address preserve: syncs only billing names in onlyNames mode without clearing billing address
• Single name field: keeps a single set of name fields for paid pickup with credit-card billing
• Immediate submit: persists pickup billing names before free-order confirmation without waiting for debounce

Quality gates

• Biome cleaned on the changed files.
• The TS2353 failure from the invalid type on the offline payment-method fixture is fixed. Remaining package tsc noise looks pre-existing / unrelated to this change.

[wcole1-godaddy]

Requesting changes for the Stripe express-checkout timeout risk. The changed-file Biome check also still has one formatting failure.

[pagrawal1-godaddy]

Addressed in 813c2b0:

• Stripe express timeout — pickup name sync no longer blocks event.resolve(). Sync starts on click and is awaited in handleConfirm before confirmation.
• Biome formatting — requireBillingNamesOnly reformatted so the changed-file biome check passes.