fix(spanner): Fix the start timestamp > end timestamp issue for change stream initial query. - #13885
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates executeExecuteChangeStreamQuery in CloudClientExecutor.java to use a new helper method timestampFromMicrosOrNanos for generating start and end timestamps, ensuring the end timestamp is not before the start timestamp. Feedback was provided regarding the use of System.nanoTime() % 1000 in the helper method, which can return negative values and alter the microsecond portion of the timestamp; using ThreadLocalRandom.current().nextInt(1000) was suggested as a safer and more appropriate alternative.
rahul2393
approved these changes
Jul 24, 2026
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sakthivelmanii
approved these changes
Jul 24, 2026
stream initial query.
Contributor
Author
|
Hi @rahul2393 and @sakthivelmanii , could you merge this PR? Thanks! |
rahul2393
approved these changes
Jul 30, 2026
rahul2393
enabled auto-merge (squash)
July 30, 2026 02:35
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.