-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(bigquery): add QueryResultsFormat and ArrowSerializationOptions configurations #13942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jinseopkim0
wants to merge
1
commit into
main
Choose a base branch
from
feat-bigquery-arrow-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
...gle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ArrowSerializationOptions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.bigquery; | ||
|
|
||
| import com.google.api.core.BetaApi; | ||
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| /** Options specific to the Apache Arrow output format. */ | ||
| @BetaApi | ||
| public final class ArrowSerializationOptions implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final String bufferCompression; | ||
| private final String picosTimestampPrecision; | ||
|
|
||
| private ArrowSerializationOptions(Builder builder) { | ||
| this.bufferCompression = builder.bufferCompression; | ||
| this.picosTimestampPrecision = builder.picosTimestampPrecision; | ||
| } | ||
|
|
||
| public String getBufferCompression() { | ||
| return bufferCompression; | ||
| } | ||
|
|
||
| public String getPicosTimestampPrecision() { | ||
| return picosTimestampPrecision; | ||
| } | ||
|
|
||
| public static Builder newBuilder() { | ||
| return new Builder(); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return com.google.common.base.MoreObjects.toStringHelper(this) | ||
| .add("bufferCompression", bufferCompression) | ||
| .add("picosTimestampPrecision", picosTimestampPrecision) | ||
| .toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| ArrowSerializationOptions that = (ArrowSerializationOptions) o; | ||
| return Objects.equals(bufferCompression, that.bufferCompression) | ||
| && Objects.equals(picosTimestampPrecision, that.picosTimestampPrecision); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(bufferCompression, picosTimestampPrecision); | ||
| } | ||
|
|
||
| com.google.api.services.bigquery.model.ArrowSerializationOptions toPb() { | ||
| com.google.api.services.bigquery.model.ArrowSerializationOptions optionsPb = | ||
| new com.google.api.services.bigquery.model.ArrowSerializationOptions(); | ||
| if (bufferCompression != null) { | ||
| optionsPb.setBufferCompression(bufferCompression); | ||
| } | ||
| if (picosTimestampPrecision != null) { | ||
| optionsPb.setPicosTimestampPrecision(picosTimestampPrecision); | ||
| } | ||
| return optionsPb; | ||
| } | ||
|
|
||
| static ArrowSerializationOptions fromPb( | ||
| com.google.api.services.bigquery.model.ArrowSerializationOptions optionsPb) { | ||
| if (optionsPb == null) { | ||
| return null; | ||
| } | ||
| return newBuilder() | ||
| .setBufferCompression(optionsPb.getBufferCompression()) | ||
| .setPicosTimestampPrecision(optionsPb.getPicosTimestampPrecision()) | ||
| .build(); | ||
| } | ||
|
|
||
| public static final class Builder { | ||
| private String bufferCompression; | ||
| private String picosTimestampPrecision; | ||
|
|
||
| private Builder() {} | ||
|
|
||
| public Builder setBufferCompression(String bufferCompression) { | ||
| this.bufferCompression = bufferCompression; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setPicosTimestampPrecision(String picosTimestampPrecision) { | ||
| this.picosTimestampPrecision = picosTimestampPrecision; | ||
| return this; | ||
| } | ||
|
|
||
| public ArrowSerializationOptions build() { | ||
| return new ArrowSerializationOptions(this); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...ery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryResultsFormat.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.bigquery; | ||
|
|
||
| import com.google.api.core.BetaApi; | ||
|
|
||
| /** The format of the query results. */ | ||
| @BetaApi | ||
| public enum QueryResultsFormat { | ||
| /** Serialized row data in Apache Arrow format. */ | ||
| ARROW, | ||
|
|
||
| /** Default encoding of results as JSON struct array. */ | ||
| STRUCT_ENCODING | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new configuration options
queryResultsFormatandarrowSerializationOptionsare currently not mapped inQueryJobConfiguration.toPb()andQueryJobConfiguration.fromPb(). As a result, these options will be silently dropped when the configuration is serialized and sent to the BigQuery service, making the feature non-functional. Please implement the mapping inQueryJobConfigurationand update this test to assert that the fields are correctly preserved during thetoPb/fromPbroundtrip.