Skip to content

fix: add documentation for insertall api that there's no default retry #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaoleMeng wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix: add documentation for insertall api that there's no default retry #13953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,12 @@ public Routine apply(com.google.api.services.bigquery.model.Routine routinePb) {
}
}

/**
* Inserts the specified rows into a table using the BigQuery insertAll API.
* Note: To prevent duplicate rows, this method does not perform automatic retries unless
* insert IDs are provided. Transient service errors (such as UNAVAILABLE) may be thrown and
* should be handled by the caller.
*/
Comment on lines +1660 to +1665

@gemini-code-assist gemini-code-assist Bot Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This Javadoc contains crucial information about the retry behavior and exception handling of the insertAll API. However, because BigQueryImpl is an internal implementation class, developers using this library typically interact with the BigQuery interface. Javadoc placed here will not be visible to users in their IDEs when calling BigQuery.insertAll(...). Please move or copy this Javadoc documentation to the insertAll(InsertAllRequest) method in the BigQuery interface so that it is properly exposed to library consumers.

@Override
public InsertAllResponse insertAll(InsertAllRequest request) {
final TableId tableId =
Expand Down
Loading