core: update SPIFFE certificate extraction to comply with X509-SVID spec - #12961
Open
kannanjgithub wants to merge 1 commit into
Open
core: update SPIFFE certificate extraction to comply with X509-SVID spec#12961kannanjgithub wants to merge 1 commit into
kannanjgithub wants to merge 1 commit into
Conversation
- Modify `SpiffeUtil.extractCert` to ignore all but the first certificate if the `x5c` JWK parameter contains multiple values.
- Modify `SpiffeUtil.extractCert` to skip the JWK entry (`continue`) instead of stopping execution (`break`) or throwing when `x5c` is missing or contains an empty list, complying with the requirement that entries without `x5c` must be
ignored.
- Update `SpiffeUtilTest.java` to treat multi-cert, missing `x5c`, and empty `x5c` list cases as success cases, asserting that the valid certificates are successfully extracted.
- Add `spiffebundle_ignored_keys.json` to verify the combination of missing `x5c`, empty `x5c` list, and multi-cert parameters.
kannanjgithub
force-pushed
the
x5c-spiffe-bundle-rework
branch
from
July 31, 2026 10:51
afb9b09 to
b44ebcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpiffeUtil.extractCertto ignore all but the first certificate if thex5cJWK parameter contains multiple values.SpiffeUtil.extractCertto skip the JWK entry (continue) instead of stopping execution (break) or throwing whenx5cis missing or contains an empty list, complying with the requirement that entries withoutx5cmust be ignored.