Decorator-first docs and demo; fix review nits (re-land #2) - #3
Merged
Conversation
- DESIGN.md: split the decorator API into implemented (first cut) vs planned knobs; mark the MaterializedFrame section's implemented subset; tick step 2 in the build order - demo: compare.py now goes through @materialize end to end (evict/flush via get_runtime for benchmark mechanics); Decimals round-trip natively - README: note that frame.sql() needs a persisted entry - decorator: frame.sql() no longer rewrites `this` inside quoted SQL literals/identifiers (review nit); documented the miss-frame .sql() behavior (review nit)
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2 was merged into its base branch after #1 had already landed on main, so its changes never reached main. This re-lands the same commit: decorator-first DESIGN.md/README/demo, quote-aware
thisrewrite in frame.sql() with regression test, and the miss-frame .sql() documentation. 68 tests, mypy + flake8 clean.