feat!: remove POST /v1/files fallback — presigned uploads required (0.7.2) - #47
Merged
Conversation
….7.2) upload_parquet() no longer falls back to the full-file-in-memory POST /v1/files path when the server returns 501; it raises a clear RuntimeError instead. The silent fallback could reintroduce the OOM the streaming path was built to fix. Verified live against prod: 120MB multipart upload peaked at +17MB RSS.
eddietejeda
enabled auto-merge (squash)
July 16, 2026 01:16
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/filesfallback fromupload_parquet()— the full-file-in-memory path that could quietly reintroduce the OOM the 0.7.1 streaming work fixed.PRESIGN_UNSUPPORTED) now raises an actionableRuntimeErrorinstead of falling back.upload_file()is never called) and adds a test locking in part_size-bounded reads.Validation
uv run pytest: 79 passed.POST /v1/uploadssession created, fallback never invoked.Breaking
Backends whose storage cannot issue presigned URLs (e.g. local MinIO clusters returning 501) now hard-fail managed-table uploads instead of using the legacy path.