Skip to content

Pr 183 - #337

Open
hyperpolymath wants to merge 3 commits into
mainfrom
pr-183
Open

Pr 183#337
hyperpolymath wants to merge 3 commits into
mainfrom
pr-183

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers


Summary by Gitar

  • CI / Tooling:
    • Added timeout-minutes to all GitHub Actions workflow jobs across the repository
    • Pinned Chapel toolchain to 2.8.0 and switched runner environment to ubuntu-22.04 in chapel-ci.yml
    • Added C++ support to CodeQL scanning analysis matrix

This will update automatically on new commits.

hyperpolymath and others added 3 commits June 1, 2026 19:23
Sibling estate repos `proven` (#141, admin-merged 2026-05-31) and
`panic-attack` (#85, the chapel-ci pilot) both moved to Chapel 2.8.0;
echidna was the lone laggard on 2.3.0. This bump closes the cross-repo
toolchain seam called out in #181.

Pattern reused verbatim from proven#141:
  * `CHAPEL_DEB_URL` -> ubuntu22 .deb at 2.8.0 (installs cleanly on the
    ubuntu24 runner image). SHA-256 verified out-of-band against the
    GitHub Releases asset
    (944a454b8a791f344312fcd261b562871159b74f5ef41d81e11833eb21d85f60).
  * `libunwind-dev` preinstall on every chapel-installing job - without
    it the chapel-built smoke binary fails to run with
    `libunwind.so.8: cannot open shared object`.
  * Top-level `env:` block hoists the version pin so all three install
    sites stay in sync; `chpl --version` echoed on each install to make
    the log self-describing.
  * No `CHPL_TARGET_*` overrides needed (sibling pattern: the 2.3.0-era
    runtime-tuple mismatch is gone on 2.8.0).

Sources audited for the four documented 2.8.0 keyword gotchas
(`out`/`label` reserved-as-locals, single-quoted char literals, Justfile
`env(...) + str` paren rule) - echidna's .chpl already uses 2.x APIs
(`createCopyingBuffer`, `sendPosixSignal`, `compareAndSwap`) and trips
NONE of them. The only source-side touch is updating one comment in
`chapel_ffi_exports.chpl` to reference the new .deb filename.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…p edge)

Chapel 2.8.0's debian package is `chapel-2.8.0-1.ubuntu22.amd64.deb`
and links its compiler driver against libclang-cpp.so.14 (Ubuntu 22.04
LLVM-14 runtime). On Ubuntu 24.04 (= ubuntu-latest) apt resolves the
unmet dep with libclang-cpp 18, leaving chpl unable to load:

  chpl: error while loading shared libraries: libclang-cpp.so.14:
        cannot open shared object file: No such file or directory
  exit code 127.

Pin runs-on: ubuntu-22.04 at all four chapel-using jobs (chapel-build,
zig-ffi, rust-chapel-feature, rust-chapel-real).

Also switch `dpkg -i ... || apt-get install -f -y` → `apt-get install -y
/tmp/chapel.deb` so apt resolves libclang-cpp14 / libllvm14 declaratively
in one pass instead of relying on the post-failure auto-fix path.

This is the 5th Chapel-2.8.0 sharp edge — sibling to the four documented
in panic-attack's wiki (MANPATH unset, CHPL_LLVM unset, `chpl --about`
dropped, `printchplenv --simple` format). Will append to that wiki.

Refs #181

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fixes Hypatia security scan failures (issuecomment-4619394163)
that caused MVP smoke test to fail across the estate.

All 26 workflow jobs now have explicit timeout-minutes declarations.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@gitar-bot

gitar-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved

Adds missing timeout-minutes to all CI workflow jobs, bumps the Chapel toolchain version to 2.8.0, and pins the runner environment. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) July 29, 2026 21:58

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant