Skip to content

Document phone_calls and tickets reassignment counters in merge preview#605

Open
marcmlc wants to merge 1 commit into
mainfrom
marcmeillac/merge-preview-openapi-reassignment-object-types
Open

Document phone_calls and tickets reassignment counters in merge preview#605
marcmlc wants to merge 1 commit into
mainfrom
marcmeillac/merge-preview-openapi-reassignment-object-types

Conversation

@marcmlc

@marcmlc marcmlc commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why?

The merge-preview response now reports ticket and phone-call reassignments as separate counters, and conversations is deduped to exclude tickets so a single record is never counted twice. The public Preview spec needs to document these counters. This is docs-only: the response passes the reassignments hash through verbatim, so the new keys reach the API with no code change.

How?

Adds tickets and phone_calls integer counters to the merge_preview_reassignments schema, redefines conversations as non-ticket conversations only, and updates the inline 200 example and endpoint prose to match. Preview spec only — the merge-preview endpoint exists only in descriptions/0/; no numbered version or fern/ override change is needed.

Tracks intercom/intercom#546485

Generated with Claude Code

Split the merge-preview reassignments object into separate counters:
conversations now excludes tickets (deduped), with tickets and
phone_calls reported separately. phone_calls is present only for
phone-lead merges. Updates the inline 200 example and endpoint prose to
match.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@marcmlc
marcmlc marked this pull request as ready for review July 24, 2026 14:27

@shrek-intercom shrek-intercom Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ PR Review Summary: APPROVE

Summary
🎯 Problem — Well-structured PR description that clearly explains the problem, rationale, and scope of the documentation-only change with appropriate context.
📝 Alignment — All claimed changes — new tickets and phone_calls fields, updated conversations description, revised inline example, and updated endpoint prose — are confirmed present in the diff with accurate details.
ℹ️ 🧠 Correctness — Disabled for this repository.
🦺 Safety — Purely additive, documentation-only changes to the Preview-tier spec with no modifications to released versions, CI/CD, or config files, making it safe to auto-approve.
🚦 Auto-approval — Within size limit (0/150 LOC).
Per-criterion details

Problem

Excellent PR description that clearly explains the problem (merge-preview response now reports separate counters, public spec needs to document them), the why (avoid double-counting, provide accurate documentation), and context (docs-only change, tracks internal issue). Concise and well-structured without excessive verbosity.

Alignment

The PR description accurately reflects the code changes in the diff:

  1. "Adds tickets and phone_calls integer counters to the merge_preview_reassignments schema" — Confirmed in the diff: both properties are added to the schema with type integer, descriptions, and examples (lines 33-39 of the patch).

  2. "Redefines conversations as non-ticket conversations only" — Confirmed: the description field is changed from "distinct conversations" to "distinct non-ticket conversations" with explicit mention that tickets are excluded and reported separately.

  3. "Updates the inline 200 example" — Confirmed: the example changes from conversations: 14 to conversations: 12, adds tickets: 2 and phone_calls: 1 (the numbers also check out: 12 + 2 = 14 original count).

  4. "Updates endpoint prose to match" — Confirmed: the endpoint description text is updated to mention "conversations, tickets, phone calls, notes, and tags" and includes clarifying language about deduplication.

  5. "Preview spec only — no numbered version or fern/ override change is needed" — Confirmed: the only file changed is descriptions/0/api.intercom.io.yaml.

  6. "docs-only: the response passes the reassignments hash through verbatim, so the new keys reach the API with no code change" — This is a contextual claim about the backend that can't be verified from this diff alone, but it's consistent with this being an OpenAPI spec documentation update.

No omissions of significant changes, no phantom claims, and the scope framing is accurate.

Safety

This PR makes purely additive, documentation-only changes confined entirely to descriptions/0/api.intercom.io.yaml — the Unstable/Preview tier spec. The changes:

  1. Add two new optional integer properties (tickets and phone_calls) to the merge_preview_reassignments schema.
  2. Update the conversations field description to clarify it excludes tickets (no type or name change — still an integer field).
  3. Update the inline response example to include the new fields.
  4. Update endpoint prose to describe the new counters.

No released version specs (descriptions/2.*/) are touched. No Fern stable overrides, scripts, CI/CD, or config files are modified. No fields or endpoints are removed. No types are changed. No enum values are removed. The change is purely additive to the unreleased Preview surface, which is explicitly in the "safe to auto-approve" category.

<violated_criteria>
</violated_criteria>

Rate this comment 👍 / 👎 to help us improve 🙏 · Disagree with assessment? Establish ground truth here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant