Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
isCapacitorNativeincore/src/utils/platform.tschecks bothcapacitor.isNativeandcapacitor.isNativePlatform(). TheisNativebranch only exists to support Capacitor 2, which predatesisNativePlatform()(added in Capacitor 3).What is the new behavior?
isCapacitorNativenow relies solely oncapacitor.isNativePlatform(). Since v9 supports Capacitor 7+, the Capacitor 2 fallback is no longer needed. This feeds our native/hybrid checks throughout the framework.Does this introduce a breaking change?
Apps running Capacitor 2 will no longer be detected as a native/hybrid platform, so
isPlatform('capacitor'),isPlatform('hybrid'), andgetPlatforms()will report web instead of native. Capacitor 2 has been out of support for a while, so migration is to upgrade to a supported Capacitor version (7 or later), which exposesisNativePlatform().Other information
This resolves FW-6255. The existing
Capacitorplatform test config already usesisNativePlatform, so the platform spec suite covers the remaining path unchanged. No component test pages are affected since this only touches the platform detection utility.Docs PR: ionic-team/ionic-docs#4592