Skip to content

fix(angular): guard transition against destroyed router outlet #31297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adahlberg-sprocket-sports wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix(angular): guard transition against destroyed router outlet #31297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/angular/common/src/directives/navigation/stack-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,10 @@ export class StackController {
enteringEl.classList.add('ion-page');
enteringEl.classList.add('ion-page-invisible');

if ((containerEl as any).commit) {
// containerEl is set to undefined when the stack controller is destroyed,
// so a transition that resolves after its outlet was destroyed must not
// dereference it (see destroy()).
if ((containerEl as any)?.commit) {
return containerEl.commit(enteringEl, leavingEl, {
duration: direction === undefined ? 0 : undefined,
direction,
Expand Down
Loading