Skip to content

Fix autobuild.yml to build merges and PRs on release/* branches - #3854

Open
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fix-autobuild-for-release-branches
Open

Fix autobuild.yml to build merges and PRs on release/* branches#3854
pljones wants to merge 1 commit into
jamulussoftware:mainfrom
pljones:fix-autobuild-for-release-branches

Conversation

@pljones

@pljones pljones commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Short description of changes

  1. Adds release/** pattern to on.push.branches and on.pull_request.branches.
  2. Makes the quoting consistent

CHANGELOG: SKIP

Context: Fixes an issue?

Direct merges to release/* or PRs to release/* would not have triggered the autobuild workflow as expected.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

I got Github CoPilot in VSCode to review it for me (it also did the quote fixes).

(Github CoPilot in VSCode GPT-5.3-Codex, 14.6 credits...)

What is missing until this pull request can be merged?

Human review.

I have no idea whether this needs backporting or whether it'll just work, either.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Copilot AI review requested due to automatic review settings August 2, 2026 17:26
@pljones pljones added the bug Something isn't working label Aug 2, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 2, 2026
@pljones pljones removed this from Tracking Aug 2, 2026
@pljones pljones added this to Tracking Aug 2, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 2, 2026
@pljones pljones added this to the Release 4.0.0 milestone Aug 2, 2026
@pljones pljones added the backport_required A change to main that needs fix on an existing release. label Aug 2, 2026
@pljones pljones removed the backport_required A change to main that needs fix on an existing release. label Aug 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the autobuild.yml GitHub Actions workflow triggers so the autobuild pipeline runs for both direct pushes/merges and pull requests targeting release/* branches, aligning CI behavior with the release branching model.

Changes:

  • Add release/** to on.push.branches so pushes/merges to release branches trigger autobuild.
  • Add release/** to on.pull_request.branches so PRs targeting release branches trigger autobuild.
  • Standardize quoting of branch/tag patterns for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pljones pljones moved this from Triage to Waiting on Team in Tracking Aug 2, 2026
@pljones pljones self-assigned this Aug 2, 2026
@ann0see

ann0see commented Aug 2, 2026

Copy link
Copy Markdown
Member

Test it on your repo.

@ann0see

ann0see commented Aug 2, 2026

Copy link
Copy Markdown
Member

And yes, it might need a backport.

@mcfnord

mcfnord commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

MY LLM WROTE:

On the backporting question: it needs it. push runs the workflow file from the pushed branch, and pull_request runs it from the base branch — so release/3_12 needs its own copy either way; merging to main won't cover it.

Consistent with what's there now: every Auto-Build run on release/3_12 is workflow_dispatch, while Verify translations does fire on push to that branch — which it can only do because the branch carries its own copy of the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Waiting on Team

Development

Successfully merging this pull request may close these issues.

4 participants