docs(JSON-RPC): connection example calls a non-existent method - #3856
Open
mcfnord wants to merge 1 commit into
Open
docs(JSON-RPC): connection example calls a non-existent method#3856mcfnord wants to merge 1 commit into
mcfnord wants to merge 1 commit into
Conversation
The "Connect to a JSON-RPC server" snippet called `jamulusserver/getServerInfo`, which the server does not implement (returns -32601 Method not found). It also skipped authentication, which every method requires. Use `jamulus/apiAuth` instead: it is a real method and the mandatory first call on any connection. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
See the first ten lines of the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MY LLM WROTE:
The "Connect to a JSON-RPC server" jayson snippet calls
jamulusserver/getServerInfo, which is not a method the server implements — a copy-paste of it returns-32601 Method not found.git log -S getServerInfoshows it entered the doc in #3101 and never existed insrc/.It's also the connection example, so it should show the one call every connection must make first:
jamulus/apiAuth. Every other method returns401 Unauthenticated: Please authenticate using jamulus/apiAuth firstuntil that runs (measured against a--jsonrpcportserver onmain:getVersion,getMode, andgetServerProfileall 401 pre-auth;getServerInfois -32601 even after auth).Changing the request to
apiAuthfixes both: it's a real method and it's the correct first step. Left as a single request so it doesn't depend on whether jayson reuses the socket across calls (auth is per-connection).