fix typo

[dingodoppelt]

Short description of changes
Fix a typo

CHANGELOG:

Context: Fixes an issue?

No

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready to merge

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[pljones]

Given it's "...Item" I'd have gone for "...ChildItems".

[dingodoppelt]

I think the name was chosen to make clear a list item (as in QTreeListItem, although QTreeWidgetItem is subclassed here) can have children.

[pljones]

It runs a loop doing delete pCurChildItem. So it's iterating over items.

[dingodoppelt]

void CConnectDlg::DeleteAllListViewItemChilds ( QTreeWidgetItem* pItem )
{
    // loop over all children
    while ( pItem->childCount() > 0 )
    {
        // get the first child in the list
        QTreeWidgetItem* pCurChildItem = pItem->child ( 0 );

        // remove it from the item (note that the object is not deleted)
        pItem->removeChild ( pCurChildItem );

        // delete the object to avoid a memory leak
        delete pCurChildItem;
    }
}

Maybe ChildItem is the misnomer then. I still think the order should be Item->Children. I think the item needs to go (pCurChild) and that would make it clearer, because we already are an item and we iterate over our children.