Apply indentation before emitting comments on new lines - #1426
Conversation
|
@SGSSGene I have fixed for failing tests and formatting. |
|
@alexprabhat99 thank you for this contribution. @jbeder this is a behavior change, without any formal specification from yaml-specs. What are your thoughts on this? |
|
I think this is fine, it's a pure ergonomic thing and the spec doesn't specify what to do here. I'd make sure it's well tested, though. |
|
@alexprabhat99 like double nested comment since you also correctly specified it in your code, I would check that FlowBlock isn't being influenced. (I am not even sure what to expect, can we even comment inside a FlowBlock?) |
|
@alexprabhat99 Any chance you could add the additional unit tests? |
|
Hi @SGSSGene , |
|
Hi @SGSSGene |
SGSSGene
left a comment
There was a problem hiding this comment.
Thank you for the PR! Highly appreciated!
Fixes: #1392