chore: update node support to LTS and current versions - #102
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 41 41
Branches 13 13
=========================================
Hits 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": "^22.11.0 || ^24.11.0 || >=26.0.0" |
There was a problem hiding this comment.
Is there a significance to these minors or should we just do >=22? Idk if there's much value excluding the odd versions even though they're unsupported.
There was a problem hiding this comment.
These are the minor versions where each Node.js release line entered LTS. Restricting support to LTS versions gives us a stable, officially supported baseline with security updates and avoids implying support for short-lived odd-numbered releases.
There was a problem hiding this comment.
One additional note: under Node.js’s new release model, these are the only unsupported odd-numbered releases. All future major release lines are expected to eventually enter LTS.
There was a problem hiding this comment.
I don't think supporting >=22 would be a bad idea either. Morgan depends on this package anyway, and using a non-LTS release hasn't caused any issues so far.
There was a problem hiding this comment.
Got it. I do agree that >=22 is probably simpler for compatibility with other packages (I'm also using >=22 in other packages) and we don't necessarily have to align with node.js support since these are mostly just JS features. Anything in 22 is likely in 23+ too.
4 participants
Node.js 18, 19, 20, 21, 23, 25 are EOL.: https://nodejs.org/en/about/previous-releases