refactor: cleanup apiservice.Binder duplication (#360)#595
Open
alokkumardalei-wq wants to merge 1 commit into
Open
refactor: cleanup apiservice.Binder duplication (#360)#595alokkumardalei-wq wants to merge 1 commit into
alokkumardalei-wq wants to merge 1 commit into
Conversation
Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Fixes #360)
This pull request addresses Issue #360 by refactoring and cleaning up the Binder logic in
cli/pkg/kubectl/bind-apiservice/plugin/binder.go.Changes made
Extracted Helper Methods:
ctx context.Context,remoteKubeconfigBytes []byte) (string, string,*rest.Config,error) to encapsulate common environment initialization logic (ensuring the client-side namespace exists, parsing/saving the remotekubeconfig, and fetching the resolved config).ctx context.Context,apiRequests []*kubebindv1alpha2.APIServiceExportRequest, remoteConfig*rest.Config,remoteNamespaceActual string,remoteKubeconfigstring) ([]*kubebindv1alpha2.APIServiceBinding, error) to handle the common request processing loop (deploying konnector, creating service export requests, saving secrets, and creating bindings).Refactored Entrypoints:
Testing and Validation
make build) that the refactored logic compiles cleanly.github.com/kube-bind/kube-bind/backend coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/auth coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/client coverage: 0.0% of statements ? github.com/kube-bind/kube-bind/backend/controllers [no test files] github.com/kube-bind/kube-bind/backend/controllers/bindableresourcesrequest coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/controllers/cluster coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/controllers/clusterbinding coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/controllers/serviceexport coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/backend/controllers/serviceexportrbac 1.695s coverage: 51.2% of statements github.com/kube-bind/kube-bind/backend/controllers/serviceexportrequest coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/controllers/servicenamespace coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/deploy coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/http coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/kubernetes coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/backend/kubernetes/resources 2.367s coverage: 4.7% of statements ok github.com/kube-bind/kube-bind/backend/oidc 1.659s coverage: 33.3% of statements ok github.com/kube-bind/kube-bind/backend/options 1.416s coverage: 9.6% of statements github.com/kube-bind/kube-bind/backend/options/session/redis coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp/controllers/apibindingtemplate coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp/controllers/apiresourceschema coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp/controllers/shared coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp/controllers/vwrbac coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/provider/kcp/options coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/session coverage: 0.0% of statements github.com/kube-bind/kube-bind/backend/session/memory coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/backend/session/redis 1.660s coverage: 81.1% of statements github.com/kube-bind/kube-bind/backend/spaserver coverage: 0.0% of statements ? github.com/kube-bind/kube-bind/backend/template [no test files] github.com/kube-bind/kube-bind/cmd/backend coverage: 0.0% of statements github.com/kube-bind/kube-bind/cmd/konnector coverage: 0.0% of statements github.com/kube-bind/kube-bind/cmd/konnector/cmd coverage: 0.0% of statements github.com/kube-bind/kube-bind/deploy/crd coverage: 0.0% of statements github.com/kube-bind/kube-bind/deploy/examples coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/bootstrap coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/committer coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/indexers coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/claimedresources 1.544s coverage: 5.7% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/claimedresourcesnamespaces coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/clusterbinding coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/namespacelifecycle coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/servicebinding 1.634s coverage: 21.2% of statements ok github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/serviceexport 1.966s coverage: 3.2% of statements ok github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/serviceexport/isolation 2.071scoverage: 5.6% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/serviceexport/multinsinformer coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/serviceexport/spec 2.209s coverage: 4.1% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/cluster/serviceexport/status coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/contextstore coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/dynamic coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/servicebinding coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/controllers/servicebindingbundle coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/options coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/server coverage: 0.0% of statements github.com/kube-bind/kube-bind/pkg/konnector/types coverage: 0.0% of statements ok github.com/kube-bind/kube-bind/pkg/resources 1.665s coverage: 57.4% of statements ok github.com/kube-bind/kube-bind/pkg/version 1.713s coverage: 88.9% of statements