Add Perl + MongoDB Quickstart (Addressed review feedback)#851
Add Perl + MongoDB Quickstart (Addressed review feedback)#851Akshat005Chaudhary wants to merge 8 commits into
Conversation
|
Hi @amaan-bhati , resubmitting this PR after addressing all previous review comments (Ref: #774). Would appreciate another look. |
amaan-bhati
left a comment
There was a problem hiding this comment.
Thanks for resubmitting and addressing the previous feedback given on #774. A few things still need to be fixed that i've segregated into blocking, should fix and nit picks:
Blocking
-
Sidebar duplication (
versioned_sidebars/version-4.0.0-sidebars.json): The diff accidentally introduces duplicateCI/CD Integrationentries (now appears 3x) and a duplicateTest Coverage Integration. There's also aK8s Proxycategory added here that has nothing to do with this PR - looks like a bad conflict resolution during rebase. Please clean this up; it'll break the v4.0.0 sidebar. -
Missing unversioned doc: The guide is only added under
versioned_docs/version-4.0.0/. The links inQuickStartList.jspoint to/docs/quickstart/perl-mongo/which resolves to the current/unversioned docs - that file doesn't exist, so the filter cards will 404. You need adocs/quickstart/perl-mongo.mdas well. -
Sample app in personal repo: Both clone commands point to your personal GitHub account. All other quickstarts use
github.com/keploy/.... Once you are 100% sure on self review on your personal repo, let me know, i'll tell you where exactly to create a pr to add the sample app.
Should fix
-
The anchor links in
QuickStartList.jsdon't match the actual heading slugs. E.g. the Docker heading is## How to run the sample application Using Docker Compose 🐳but the link uses#running-app-using-docker-compose-. Double-check both anchors. -
Local
keploy testcommand is missing--delay- the Docker version has it (--delay 10). Add it for consistency. -
Heading levels in the local section are inconsistent - subsections jump to
##where the Docker section uses###. Keep them###.
Nits
- "Keploy with capture" → "will capture" (appears twice)
shortUrl: "http://localhost:5000QWERTY"is missing a/- should behttp://localhost:5000/QWERTY- Image alt text is literally
alt textin both places - make it descriptive, helps in seo and image failure as well.
|
Hi @amaan-bhati, I have addressed all the PR feedback. Here is a summary of the changes: Blocking
Should Fix
Nits
I've successfully verified the build locally with |
amaan-bhati
left a comment
There was a problem hiding this comment.
Good progress here, most of the previous issues have been addressed. The sample app is now under the keploy org, the unversioned doc is included, sidebar is clean, anchor links look correct, and the --delay flag is in both test commands. Just a few small things left to fix.
One thing to note: whatever changes are needed in docs/quickstart/perl-mongo.md apply equally to versioned_docs/version-4.0.0/quickstart/perl-mongo.md since both files are identical. Please update both together.
| - Auto case generation | ||
| --- | ||
|
|
||
| import Link from '@docusaurus/Link' |
There was a problem hiding this comment.
Link is imported here but never used anywhere in the file. Can you remove this import?
| curl -v http://localhost:5000/QWERTY | ||
| ``` | ||
|
|
||
| This is return 302 status code and redirect to the original url if code is correct. |
There was a problem hiding this comment.
"This is return" should be "This will return". Same issue appears again in the local setup section further down, please fix both.
| curl http://localhost:5000/XXXXXX | ||
| ``` | ||
|
|
||
| This is give error: |
There was a problem hiding this comment.
"This is give error" should be "This will give an error". Same issue appears in the local setup section too.
|
|
||
| <SectionDivider /> | ||
|
|
||
| ## Running App Locally on Linux/WSL 🐧 |
There was a problem hiding this comment.
The heading says Linux/WSL but the install instructions below cover macOS (brew install cpanminus) and Windows (cpan App::cpanminus) as well. Either update the heading to "Running App Locally on Linux/WSL/macOS" to reflect the actual content, or decide to drop the macOS/Windows steps if the intent is strictly Linux/WSL.
|
|
||
|  | ||
|
|
||
| Keep an eye out for the `-c `flag! It's the command charm to run the app. |
There was a problem hiding this comment.
There's a trailing space inside the backtick here: `-c ` should be `-c`. Small but it renders with the space included.
|
Hi @amaan-bhati, I have addressed the review feedback and pushed the updates:
Both the unversioned and versioned docs have been updated. Ready for your review! |
dhananjay6561
left a comment
There was a problem hiding this comment.
Thanks for the resubmission @Akshat005Chaudhary! Left a couple of inline comments.
One blocker: the guide clones https://github.com/keploy/samples-perl.git, but that repo isn't live under the keploy org yet (it 404s), so the quickstart can't actually be followed end-to-end. Could you share the current link where the sample app lives? Once it's up under keploy, we can confirm the clone URL, the --container-name=perl-app value, and the endpoint responses match the app.
| server: "Local", | ||
| description: | ||
| "A sample URL Shortener app to demonstrate Keploy integration capabilities using Perl and MongoDB.", | ||
| link: "/docs/quickstart/perl-mongo/#running-app-locally-on-linuxwsl-", |
There was a problem hiding this comment.
This anchor looks like it'll break. The heading in the guide is ## Running App Locally on Linux/WSL/macOS 🐧, which Docusaurus slugifies to running-app-locally-on-linuxwslmacos- — but this link points to running-app-locally-on-linuxwsl- (missing macos), so the "Local" card won't scroll to the right section.
The existing samples use the heading Running App Locally on Linux/WSL 🐧 (no /macOS), which is why their #running-app-locally-on-linuxwsl- anchors work. Easiest fix: match that heading in the guide, otherwise update this link to #running-app-locally-on-linuxwslmacos-.
| Clone the repository and move to relevant folder | ||
|
|
||
| ```bash | ||
| git clone https://github.com/keploy/samples-perl.git |
There was a problem hiding this comment.
keploy/samples-perl doesn't resolve — this repo isn't live under the keploy org, so the clone fails and the guide can't be followed. Could you share the current link to the sample app? (Same clone URL is also used in the local-setup section on line 162, and in docs/quickstart/perl-mongo.md.)
|
Hi @dhananjay6561 and @amaan-bhati, Here's the sample Perl + MongoDB app I've built for this quickstart: @amaan-bhati — as discussed earlier, could you let me know where to |
|
Hey @Akshat005Chaudhary, thanks for the contribution and for addressing the earlier feedback! I tested the flow along with the docs and everything seems to be working properly — setup instructions (both Docker and Local), the record/replay commands, and the endpoints all check out. Nice work. One suggestion though: while the app is good and everything works, I feel the quickstart isn't really showcasing Keploy's full capabilities right now. It's a pretty small use case — the URL shortener only exposes a handful of calls (POST /shorten, redirect, stats, and one negative case). I'd recommend taking a look at some of the other quickstarts we have to see how they demonstrate more of what Keploy can do, and then improving this one along the same lines. Specifically:
This would make the quickstart much more representative of how Keploy performs in a real project. Let me know if you need any pointers on the other quickstarts to reference! |
Summary
This PR re-submits the Perl + MongoDB Quickstart after addressing feedback from the previous review.
Ref: #774
Updates Based on Review
keploy recordandkeploy testusage for both Docker and local setups are clearly documented for the ease of beginners, with explicit references to sections being attacked below.Keploy Record in local setup

Keploy Test in local setup

Keploy Record in Docker setup

Keploy Test in Docker setup

Notes
All feedback from the previous review has been addressed.
Happy to make further improvements if needed.