feat(api): update API spec from langfuse/langfuse 2cb776a - #1798
feat(api): update API spec from langfuse/langfuse 2cb776a#1798langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — routine auto-generated API spec sync from langfuse/langfuse, no bugs found.
Extended reasoning...
Overview
This PR is an auto-generated update to the Python API client (via Fern) mirroring an upstream API spec change in langfuse/langfuse. It touches metrics/client.py, metrics/raw_client.py, observations/client.py, observations/raw_client.py, and evaluation_rule_filter.py. Changes are: (1) a new optional session_id pass-through parameter on ObservationsClient.get_many/RawObservationsClient.get_many, threaded through to the sessionId query param exactly like the existing user_id/trace_id parameters; (2) docstring-only additions describing the isRootObservation v2 metrics dimension and a boolean filter example; and (3) docstring additions across the EvaluationRuleFilter_* Pydantic models documenting a boolean filter type/operator on the isRootObservation column — the underlying EvaluationRuleBooleanFilterOperator enum and EvaluationRuleFilter_Boolean model already existed pre-PR and are unchanged.
Security risks
None. No auth, crypto, or permission logic is touched. The new parameter is a simple optional string forwarded verbatim as a query parameter, matching the existing pattern for other filter parameters (, , etc.) in the same file.
Level of scrutiny
Low. This is boilerplate, auto-generated client code following an established mechanical pattern (add optional kwarg → thread through raw client → add to params dict → document in docstring). There is no hand-written business logic, and the same additive pattern is repeated identically across sync/async variants, which is standard for this Fern-generated codebase.
Other factors
No CODEOWNERS-restricted paths are touched, no existing review comments are outstanding on this PR, and the bug-hunting pass found no issues. The change is purely additive (new optional parameter, expanded docs) with no removed or altered existing behavior.
Greptile Summary
The regenerated API client adds session-ID filtering to synchronous and asynchronous observation listing and documents semantic-root filtering for metrics and evaluation rules.
Confidence Score: 5/5
The PR appears safe to merge with no actionable correctness or security issues identified.
The new observation filter is consistently forwarded through synchronous and asynchronous layers and encoded using the established sessionId query convention, while the remaining changes are generated API documentation updates.
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile