fix(license): repair the 404 license link, and make GitHub detect MIT - #44
Merged
Conversation
…g main branch product.overlay.json set licenseUrl/serverLicenseUrl to github.com/levelcodeai/levelcode/blob/main/LICENSE, but there is no `main` branch — the default is `develop` — so the license link baked into the app's About / license metadata 404'd. Use /blob/HEAD/LICENSE: GitHub resolves HEAD to whatever the default branch is, so it works on develop today and survives a future rename to main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…bution to NOTICE GitHub's license API reported NOASSERTION (not MIT) for this repo: the derivative and Microsoft-trademark paragraph appended after the MIT text pushed the file below the detector's template-match threshold, so the repo carried no MIT label. Split it the way upstream VS Code does — LICENSE is now verbatim MIT (the grant and the copyright line are unchanged), and the Code-OSS provenance + trademark disclaimer move to a dedicated NOTICE file. README's License section points at both. Nothing is lost; MIT now detects. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes LevelCode’s license metadata and repository license hygiene so the in-app license link no longer 404s (independent of default-branch name) and GitHub can correctly classify the repository as MIT.
Changes:
- Update product metadata license URLs to use
blob/HEAD/LICENSEinstead of a hardcodedmainbranch. - Restore
LICENSEto a verbatim MIT License text to satisfy GitHub/licensee detection. - Move derivative/trademark/provenance language into a new
NOTICEfile and link it from the README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates the License section to reference both LICENSE and the new NOTICE for attributions. |
| NOTICE | Adds a dedicated notice file for derivative/trademark/provenance statements removed from LICENSE. |
| LICENSE | Removes the appended non-MIT block so the file is pure MIT (improves GitHub license detection). |
| branding/product.overlay.json | Fixes licenseUrl/serverLicenseUrl to use HEAD to avoid default-branch 404s. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report
https://github.com/levelcodeai/levelcode/blob/main/LICENSEreturns 404.Two root causes (the second found while fixing the first)
1. The link pointed at a branch that doesn't exist.
branding/product.overlay.jsonhardcodedlicenseUrl/serverLicenseUrlto/blob/main/LICENSE, but there is nomainbranch — the default isdevelop. So the license link baked into the app's About / license metadata 404'd. TheLICENSEfile itself was fine and present all along.Fixed to
/blob/HEAD/LICENSE. GitHub resolvesHEADto whatever the default branch is, so it works ondeveloptoday and survives a future rename tomain— no branch has to be created.2. GitHub wasn't detecting the license as MIT. While verifying, the license API reported:
NOASSERTIONmeans the detector couldn't classify the file — so the repo carried no "MIT License" label. Cause: the derivative / Microsoft-trademark paragraph appended after the MIT text pushed the file belowlicensee's template-match threshold.Fixed the way upstream VS Code does it —
LICENSEis now verbatim MIT (the grant and the copyright line are byte-for-byte unchanged; see the diff — only the trailing block was removed), and the Code-OSS provenance + trademark disclaimer move to a dedicatedNOTICEfile. The README's License section now points at both. Nothing is lost, and MIT will detect once this lands on the default branch.Commits
d9755a6— product license URLmain→HEAD(the 404 fix)cbf4f4f—LICENSE→ pure MIT, attribution → newNOTICE, README pointerVerification
product.overlay.jsonstill parses as JSON; both?ref=HEADand?ref=developserveLICENSE.LICENSEdiff removes only the appended block — the MIT terms andCopyright (c) 2026 Sergii Demianchuk (LevelCode)are untouched.NOTICEis plain ASCII.Kept intentionally separate from the pending
RELEASE-NOTES.mdv1.0.0 change.🤖 Generated with Claude Code