fix(rtc): handle repeated local track subscription events - #771
Merged
lukasIO merged 1 commit intoJul 31, 2026
Merged
Conversation
swayamg20
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
July 30, 2026 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #770
Problem
During a full reconnect, the server can resend
local_track_subscribedfor a reusedLocalTrackPublication. Its_first_subscriptionfuture is one-shot and already resolved, so callingset_result(None)again raisesasyncio.InvalidStateError._listen_taskcatches the exception, logs an error, and drops the repeated event.Fix
Only resolve
_first_subscriptionwhile it is pending. The handler still emitslocal_track_subscribedfor every event, preserving callback behavior across reconnects.The regression test dispatches the same event twice and verifies both branches:
wait_for_subscription();Testing
InvalidStateErroron the unguarded handler and passes with this change.MACOSX_DEPLOYMENT_TARGET=11.0 uv run pytest livekit-rtc/tests -q— 33 passed, 14 skipped.livekit-protocol,livekit-api, andlivekit-rtc/livekit.make build-wheel PACKAGE=livekit-rtcsucceeds.The full root test command also reached 48 passed and 30 skipped. Three audio-fixture tests could not run locally because Git LFS was unavailable and the WAV fixtures remained pointer files; CI is configured to fetch those LFS assets.