-
Notifications
You must be signed in to change notification settings - Fork 37
DOC-317: document EKS_K3D_VERSION config option #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarshCasper
wants to merge
7
commits into
aws-docs-release-july
Choose a base branch
from
doc-317-doc-fix-update-k3d-version-in-eks-to-590-aws-1071
base: aws-docs-release-july
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ebbdc58
DOCS: add NEW github actions workflow feature-branch-only-to-main (#734)
quetzalliwrites 2bb2dd6
DOC-287: Drop Flink 1.13 runtime (#742)
blkgrlcto 1dc0507
DOC-313: Kinesis: add option for a rust based mock (#731)
jbeemster 0f3b02c
DOCS: (hotfix to `main`) Add release notes for latest Snowflake relea…
quetzalliwrites 6607043
DOC-313: (hotfix to `main`) Kinesis: add option for a rust based mock…
quetzalliwrites e13619c
document SCP enforcement for cross-account access (#716)
HarshCasper a85f679
DOC-317: document EKS_K3D_VERSION config option
HarshCasper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: "Restrict Docs PR merges" | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, edited] | ||
|
|
||
| jobs: | ||
| validate-refs: | ||
| name: "Validate Refs" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Validate | ||
| run: | | ||
| # We allow merging to a branch which is a feature branch for documentation. | ||
| if [[ $GITHUB_BASE_REF == aws-docs-* || $GITHUB_BASE_REF == snowflake-docs-* ]]; then | ||
| echo "Merging to a feature branch. Allowing." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # We allow merging to main so long as it's from a feature branch for documentation. | ||
| if [[ $GITHUB_BASE_REF == main && ($GITHUB_HEAD_REF == aws-docs-* || $GITHUB_HEAD_REF == snowflake-docs-*) ]]; then | ||
| echo "Merging feature branch to main. Allowing." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # All other scenarios aren't valid for merging. | ||
| echo "Please ensure all changes are merged to a feature branch. Only feature branches can be merged into main. Rejecting." | ||
| exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to be explicit that we're talking about AWS Policy Simulator in these three points