fix(cli): classify failures and partial de-panic in the client library - #489
Merged
Harsh4902 merged 3 commits intoJul 27, 2026
Merged
Conversation
This was referenced Jul 9, 2026
|
supersede #481 |
|
DCO is required. |
Caesarsage
force-pushed
the
pr1/classify-errors-and-depanic
branch
from
July 23, 2026 08:48
c44f139 to
f8c27a0
Compare
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Caesarsage
force-pushed
the
pr1/classify-errors-and-depanic
branch
from
July 23, 2026 08:57
f8c27a0 to
732b4ae
Compare
Contributor
Author
|
fixed @Vaishnav88sk |
|
Suggestion:
|
|
After that LGTM. 👍🏻 |
Caesarsage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Microcks CLI v2 work #255.
Introduces a small Failure Kind vocabulary in
pkg/errors(Kind,Wrap/Wrapf,KindOf, and anErrTestFailedsentinel) and makes the client library return classified errors instead of panicking or exiting.Why
pkg/connectorsandkeycloak_clientpreviouslypanic'd on runtime errors (bad response body, unreachable server). A library that can take down its host process is unsafe to embed, which the planned VS Code extension needs to do. Kinds are the library's vocabulary; exit codes stay a CLI concern (added in next PR ()), sopkg/*never depends on them.Notable
Fixes two real latent bugs found while de-panicking:
openIDResp["access_token"].(string): the CLI crashed on a Keycloak 401 instead of reporting it.Scope / safety
Additive and non-breaking: the legacy
CheckError/Fatalshim and the existing constructor signatures are untouched here (removed/changed in later PRs). Build + tests green.