Skip to content

Fix topic sidebar toggle styling#1370

Open
IEvangelist wants to merge 1 commit into
mainfrom
ievangelist-fix-topic-collapse-icon
Open

Fix topic sidebar toggle styling#1370
IEvangelist wants to merge 1 commit into
mainfrom
ievangelist-fix-topic-collapse-icon

Conversation

@IEvangelist

Copy link
Copy Markdown
Member

Summary

  • keep topic landing-page collapse and expand icons transparent and borderless when no On this page bar is present
  • preserve the existing bar styling on API reference and topic pages that render the mobile TOC

Validation

  • verified the landing page and regular topic page at affected viewport widths using the local dev server and playwright-cli

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 17, 2026 13:33
@IEvangelist
IEvangelist enabled auto-merge (squash) July 17, 2026 13:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the “floating” sidebar collapse/expand toggle styling in Sidebar.astro so that topic landing pages (where the mobile “On this page” TOC bar is not present) don’t render the toggle as a leftover TOC bar fragment, while preserving the existing in-bar styling on pages that do render the mobile TOC bar (and keeping API reference behavior intact).

Changes:

  • Refines the no-TOC, 50–99.999rem breakpoint styling by splitting “in-bar” visuals by toggle ID (#sidebar-* vs #topic-sidebar-*).
  • Keeps the shared positioning behavior for both toggles, while making topic toggle backgrounds/borders transparent when no TOC bar is present.
  • Adds explicit hover handling for topic toggles in the no-TOC scenario to prevent reintroducing a bar-like background.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1370. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1370 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants