fix(test): increase Intel macOS timeout#41851
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 696f2d8a-c16c-4d90-8353-8e33d66a2c31
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Test results for "tests 1"6 flaky50369 passed, 1158 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 Both failures are pre-existing flakes — this PR is clearThe two MCP failures are known flaky tests that fail across unrelated PRs and browsers, and neither is a test this PR touches. This PR only adjusts timeouts and DetailsThe MCP report lists 2 failed: Pre-existing flake / infra
Assessment: neither failure reaches any code the diff changed. The timeout bump ( Triaged by the Playwright bot - agent run |
| annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' }, | ||
| }, async ({ browserType, createUserDataDir, browserName }) => { | ||
| it.fixme(browserName === 'firefox'); | ||
| it.slow(); |
There was a problem hiding this comment.
This effectively decreases timeout from 90s to 60s, maybe leave it as is?
This is based on 285
mainpush runs from thetest-resultsdatabase. Intel macOS runners regularly push unrelated library tests close to the 30s timeout, so this raises their default to 60s.It also removes six
.slow()calls that are no longer needed with the new default, or whose tests consistently finish well below 30s.