Skip to content

fix(test): increase Intel macOS timeout#41851

Open
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-adjust-test-timeouts
Open

fix(test): increase Intel macOS timeout#41851
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-adjust-test-timeouts

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Jul 17, 2026

Copy link
Copy Markdown
Member

This is based on 285 main push runs from the test-results database. Intel macOS runners regularly push unrelated library tests close to the 30s timeout, so this raises their default to 60s.

It also removes six .slow() calls that are no longer needed with the new default, or whose tests consistently finish well below 30s.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 696f2d8a-c16c-4d90-8353-8e33d66a2c31
@Skn0tt
Skn0tt requested a review from dgozman July 17, 2026 15:46
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/annotate.spec.ts:173 › user-initiated annotate downloads zip with feedback.md @mcp-ubuntu-latest-chrome
❌ [chromium] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid @mcp-macos-latest-chromium

7758 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:211 › should intercept service worker requests (main and within) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/har-websocket.spec.ts:235 › should attach websocket messages `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:282 › should click `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:255 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:778 › should partition action tree state by test `@windows-latest-node22`

50369 passed, 1158 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 Both failures are pre-existing flakes — this PR is clear

The two MCP failures are known flaky tests that fail across unrelated PRs and browsers, and neither is a test this PR touches. This PR only adjusts timeouts and test.slow() markers in the library suite; the MCP suite has its own config, so it isn't affected.

Details

The MCP report lists 2 failed:

Pre-existing flake / infra

  • [chrome] › mcp/annotate.spec.ts:173 › user-initiated annotate downloads zip with feedback.md — flaky across the test-results DB on unrelated SHAs: firefox failed 12/269, webkit 10/276, chrome 3/274, chromium 2/273 runs, spanning 10+ different PRs. Note this is a different test from the two annotate.spec.ts tests this PR edits (it only removed test.slow() from should capture annotations via show --annotate and should disengage annotate mode…), and :173 was left untouched.

  • [chromium] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid — flaky on unrelated SHAs: chromium failed 7/273, webkit 4/276, firefox 3/269, chrome 2/274 runs, across 5+ different PRs. This PR doesn't touch cli-killall.spec.ts at all.

Assessment: neither failure reaches any code the diff changed. The timeout bump (tests/library/playwright.config.ts) and the removed test.slow() calls are confined to the library suite and to tests that aren't the ones failing here. Both failures match tests with a documented cross-PR flake history, so this PR isn't the cause.

Triaged by the Playwright bot - agent run

annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' },
}, async ({ browserType, createUserDataDir, browserName }) => {
it.fixme(browserName === 'firefox');
it.slow();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively decreases timeout from 90s to 60s, maybe leave it as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants