Fix #26034: interpreter selection reverting to default interpreter#26063
Open
mohityadav8 wants to merge 1 commit into
Open
Fix #26034: interpreter selection reverting to default interpreter#26063mohityadav8 wants to merge 1 commit into
mohityadav8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26034
Root Cause
ms-python.vscode-python-envsinstalled butpython.useEnvironmentsExtensionis not explicitly set,shouldEnvExtHandleActivation()correctly yields control of the status bar to the Environments extension. However,setInterpreter.tsandresetInterpreter.tswere only checkinguseEnvExtension(), meaning they never reported interpreter selections to the Environments extension. The visible status bar therefore kept showing its default when working outside a workspace.getActiveInterpreter()races resolution against a 100ms timeout. On timeout, it falls back to a cached value. Previously, this cache wasn't cleared on config changes, so slow resolutions would surface old interpreters in the UI and get stuck there.Changes
setInterpreter.ts,resetInterpreter.ts, andinterpreterService.ts(resolveActiveInterpreter) to checkuseEnvExtension() || shouldEnvExtHandleActivation()..catch()handling around legacy calls so synchronization failures don't undo the native setting._onConfigChangedininterpreterService.tsto clearlastKnownActiveInterpreterand in-flight states when paths change.timedOutActiveInterpreterKeystracking to proactively trigger a display refresh once delayed resolutions finally complete.shouldEnvExtHandleActivationStubto associated unit tests to support the widened logic gate.