Compose alternate-result filters with typed server handlers#1718
Closed
onatozmenn wants to merge 2 commits into
Closed
Compose alternate-result filters with typed server handlers#1718onatozmenn wants to merge 2 commits into
onatozmenn wants to merge 2 commits into
Conversation
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
Author
|
#1722 covers the same composition fix and it's merged, so this is redundant now. Closing it. One note for next time: I'd commented on #1704 that I was picking up this slice and opened this PR two days before #1720 came in, so a ping on the issue when #1722 started would have saved the duplicate work. I do get that a P0 regression during an rc has its own timeline. The part of #1704 that still looks open to me is the method-agnostic seam. I'll follow up there rather than reopen this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate-result handlers currently replace the normal typed server pipeline. For Tasks, that means enabling task support can bypass ordinary tool filters such as validation, telemetry, and ASP.NET authorization.
This PR lets extension-owned alternate results wrap the existing pipeline instead:
AddAlternateResultFilterAPI.MatchedPrimitiveset.CallToolWithAlternateHandleras the explicit replacement API and reports incompatible registrations at startup.This covers the alternate-result composition part of #1704. Custom RPC registration and subscription grants remain follow-up work.
How Has This Been Tested?
dotnet format whitespace --verify-no-changesandgit diff --checkpass.Breaking Changes
No stable API break. The new API is experimental. Registering both an explicit
CallToolWithAlternateHandlerand a method-keyed alternate-result filter now fails at startup because the explicit handler is a full replacement.Types of changes
Checklist
Additional context
Tasks is the first consumer, using
tools/call. Tests also coverprompts/getandprompts/listto make sure the registration is not tool-specific.