Rename MCPEXP002 Subclassing_* constants to Extensibility_*#1739
Conversation
1311fbc to
b7f1896
Compare
PranavSenthilnathan
left a comment
There was a problem hiding this comment.
I validated that the list of diagnostics is up to date with all experimental and obsolete diagnostic IDs currently defined by the SDK. Modulo the minor inline suggestions to clarify the purpose and expected lifetime of the MCPEXP002 extensibility APIs, this looks good.
Requesting changes so those documentation clarifications can be incorporated before merge.
Note
This review comment was generated with AI assistance.
|
Applied all three suggestions verbatim in Two things the new text drops that were in the old row, flagging in case either was intentional to keep:
Happy to fold either back in if you want them retained. |
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks for tackling this, @arimu1!
Align internal constant names and documentation with MCPEXP002's actual scope: experimental C# SDK extensibility APIs beyond subclassing alone. Diagnostic ID and suppression behavior are unchanged. Fixes modelcontextprotocol#1736
Apply review suggestions: describe MCPEXP002 as the extensibility surface that lets features ship in standalone packages without Core awareness (Tasks being the current consumer), and state that the APIs stay experimental until more extensibility scenarios validate the design.
af6028d to
f41f2b7
Compare
|
Rebased onto
Both are extensibility points in the same group as the enclosing |
Summary
Experimentals.Subclassing_DiagnosticId,Subclassing_Message, andSubclassing_UrltoExtensibility_*so internal naming matches MCPEXP002's actual scope (C# SDK extensibility APIs, not only subclassing).docs/list-of-diagnostics.mdto describe MCPEXP002 consistently as experimental extensibility points in the C# implementation.[Experimental(...)]call sites that referenced the old constants.Fixes #1736
Notes
MCPEXP002as before.Test plan
dotnet build src/ModelContextProtocol.Core/ModelContextProtocol.Core.csproj— succeeded (0 warnings, 0 errors)dotnet build tests/ModelContextProtocol.ExperimentalApiRegressionTest/ModelContextProtocol.ExperimentalApiRegressionTest.csproj— succeededdotnet build/dotnet test(not run here — disk space limited on build machine; mechanical rename only)