arged responses by lorenzo132 · Pull Request #3418 · modmail-dev/Modmail

lorenzo132 · 2025-12-13T15:04:44Z

This add a args feature, for example if your arg is called argreply

You can do: `?reply Hello, read the following: {argreply}

This add a args feature, for example if your arg is called `argreply` You can do: `?reply Hello, read the following: {argreply}

sebkuip

There are some issues in this PR that need to be addressed beforehand.

StephenDaDev · 2026-06-15T11:49:04Z

I discussed this with Lorenzo and removed this from this update to allow additional time for corrections while still working towards the important changes in 4.3.0

martinbndr

Looks good to me

StephenDaDev

seems fine w/ changes

sebkuip

I found some bugs, and some typos. Please have these fixed. Thanks!

sebkuip · 2026-07-13T11:42:13Z

Small typo here, pointed out by copilot. "don't" is missing it's apostrophe

sebkuip · 2026-07-13T11:43:12Z

I would change this text to See"{self.bot.prefix}help args add" for how to add an arg.

sebkuip · 2026-07-13T11:43:39Z

Needs a comma after "simply"

sebkuip · 2026-07-13T11:54:58Z


        if self.bot.args:
-            msg = UnseenFormatter().format(msg, **self.bot.args)
+            msg = self.bot.formatter.format(msg, **self.bot.args)


The system breaks when an arg with a . character in the name is added. It tries to resolve it as an attribute causing either an <invalid> or an error to appear.

Using a string as an arg causes no reply and a silent error.

Using a forbidden arg causes an <invalid> to appear (here I did ?r testing {channel.name})

Formatreply correctly works and doesn't cause issues

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

cogs/modmail.py:1726

In the reply command, running SafeFormatter.format() on every message when any args exist will replace any unknown {...} placeholders with "<Invalid>" (per SafeFormatter.get_field), changing existing reply behavior for messages that include braces. Consider only substituting placeholders that match defined args, leaving other braces untouched (users can use freply for full variable formatting).

        if self.bot.args:
            msg = self.bot.formatter.format(msg, **self.bot.args)

cogs/modmail.py:587

Typo/grammar: "You dont have any args" should use an apostrophe ("don't").

            embed = discord.Embed(
                color=self.bot.error_color,
                description="You dont have any args at the moment.",
            )

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (5)

cogs/modmail.py:688

args_edit stores the new value without commands.clean_content, while args_add uses clean_content. This makes edits behave differently than adds and can reintroduce mentions/markdown that add would have sanitized.

    @args.command(name="edit")
    @checks.has_permissions(PermissionLevel.SUPPORTER)
    async def args_edit(self, ctx, name: str.lower, *, value):
        """
        Edit an arg.

cogs/modmail.py:1762

Passing **self.bot.args alongside explicit channel=..., recipient=..., author=... can raise TypeError: got multiple values for keyword argument if the config already contains any reserved keys (e.g. from manual edits or older data). Build a single kwargs dict and let the reserved keys override.

        msg = self.bot.formatter.format(
            msg,
            **self.bot.args,
            channel=ctx.channel,
            recipient=ctx.thread.recipient,

cogs/modmail.py:1800

Same reserved-key collision risk as freply: expanding **self.bot.args together with explicit channel/recipient/author can throw TypeError if those keys exist in config. Merge into a single dict so reserved values overwrite safely.

        msg = self.bot.formatter.format(
            msg,
            **self.bot.args,
            channel=ctx.channel,
            recipient=ctx.thread.recipient,

cogs/modmail.py:1838

Same reserved-key collision risk as freply: expanding **self.bot.args together with explicit channel/recipient/author can throw TypeError if those keys exist in config. Merge into a single dict so reserved values overwrite safely.

        msg = self.bot.formatter.format(
            msg,
            **self.bot.args,
            channel=ctx.channel,
            recipient=ctx.thread.recipient,

cogs/modmail.py:1876

Same reserved-key collision risk as freply: expanding **self.bot.args together with explicit channel/recipient/author can throw TypeError if those keys exist in config. Merge into a single dict so reserved values overwrite safely.

        msg = self.bot.formatter.format(
            msg,
            **self.bot.args,
            channel=ctx.channel,
            recipient=ctx.thread.recipient,

+    def get_field(self, field_name, args, kwargs):
+        """Resolve only complete field names and preserve unknown fields."""
+        if field_name in kwargs:
+            return kwargs[field_name], field_name
+        if field_name.isdecimal():


+        To create an arg:
+        - `{prefix}args add arg-name A value.`
+
+        You can use your arg in a reply with `{arg-name}`.
+        """


+        if len(name) > 120:
+            embed = discord.Embed(
+                title="Error",
+                color=self.bot.error_color,
+                description="Arg names cannot be longer than 120 characters.",
+            )
+            return await ctx.send(embed=embed)


+        if len(value) > 120:
+            embed = discord.Embed(
+                title="Error",
+                color=self.bot.error_color,
+                description="Arg names cannot be longer than 120 characters.",
+            )
+            return await ctx.send(embed=embed)


+            )
+            return await ctx.send(embed=embed)
+
+        embeds = [discord.Embed(color=self.bot.main_color) for _ in range((len(self.bot.args) // 10) + 1)]


+        if self.bot.args:
+            msg = UnseenFormatter().format(msg, **self.bot.args)
+


lorenzo132 added 2 commits December 13, 2025 16:00

feat: args

312f137

This add a args feature, for example if your arg is called `argreply` You can do: `?reply Hello, read the following: {argreply}

fix linting

0bd96b8

lorenzo132 mentioned this pull request Dec 13, 2025

args for snippets/aliases #3384

Closed

2 tasks

lorenzo132 requested review from ModmailTest, StephenDaDev, Taaku18, martinbndr and sebkuip December 13, 2025 15:05

lorenzo132 changed the title ~~Users/lorenzo132/arged responses~~ arged responses Dec 13, 2025

martinbndr previously approved these changes Dec 13, 2025

View reviewed changes

StephenDaDev removed the request for review from ModmailTest December 14, 2025 01:34

StephenDaDev previously approved these changes Dec 14, 2025

View reviewed changes

Comment thread cogs/modmail.py

Comment thread cogs/modmail.py

change wording

fed5044

lorenzo132 dismissed stale reviews from StephenDaDev and martinbndr via fed5044 December 14, 2025 02:42

Merge branch 'development' into users/lorenzo132/arged-responses

3972f9c

StephenDaDev previously approved these changes Dec 14, 2025

View reviewed changes

lorenzo132 requested a review from martinbndr December 17, 2025 16:00

StephenDaDev added the changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. label Dec 18, 2025

lorenzo132 and others added 2 commits December 20, 2025 20:42

Merge branch 'development' into users/lorenzo132/arged-responses

b3dd8a0

fix: help args

b1136e5

Copilot AI review requested due to automatic review settings December 27, 2025 14:01

lorenzo132 dismissed StephenDaDev’s stale review via b1136e5 December 27, 2025 14:01

Copilot started reviewing on behalf of lorenzo132 December 27, 2025 14:02 View session

lorenzo132 requested a review from StephenDaDev December 27, 2025 14:03

This comment was marked as spam.

Sign in to view

lorenzo132 added 2 commits January 15, 2026 11:45

Merge branch 'development' into users/lorenzo132/arged-responses

bab4fdb

Merge branch 'development' into users/lorenzo132/arged-responses

95751df

Copilot AI review requested due to automatic review settings January 16, 2026 12:46

Copilot started reviewing on behalf of lorenzo132 January 16, 2026 12:47 View session

lorenzo132 dismissed martinbndr’s stale review via d683a42 March 1, 2026 19:38

martinbndr previously approved these changes Mar 2, 2026

View reviewed changes

martinbndr requested a review from StephenDaDev March 2, 2026 10:29

StephenDaDev previously approved these changes Mar 4, 2026

View reviewed changes

sebkuip requested changes Mar 7, 2026

View reviewed changes

Comment thread cogs/modmail.py

Comment thread cogs/modmail.py Outdated

Comment thread cogs/modmail.py

Comment thread cogs/modmail.py

Comment thread cogs/utility.py Outdated

StephenDaDev removed the changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. label Jun 15, 2026

lorenzo132 and others added 2 commits June 15, 2026 18:46

Merge branch 'development' into users/lorenzo132/arged-responses

71a8f54

resolve change request.

041b23e

lorenzo132 dismissed stale reviews from StephenDaDev and martinbndr via 041b23e June 15, 2026 16:53

lorenzo132 requested review from StephenDaDev, martinbndr and sebkuip and removed request for martinbndr June 15, 2026 16:54

martinbndr previously approved these changes Jun 20, 2026

View reviewed changes

StephenDaDev previously approved these changes Jul 13, 2026

View reviewed changes

sebkuip requested changes Jul 13, 2026

View reviewed changes

StephenDaDev added the changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. label Jul 13, 2026

Merge branch 'development' into users/lorenzo132/arged-responses

82faceb

Copilot AI review requested due to automatic review settings July 18, 2026 22:40

Copilot started reviewing on behalf of lorenzo132 July 18, 2026 22:41 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

Comment thread cogs/modmail.py

Resolve git requests.

8d97f94

Copilot AI review requested due to automatic review settings July 18, 2026 23:00

lorenzo132 dismissed stale reviews from StephenDaDev and martinbndr via 8d97f94 July 18, 2026 23:00

Copilot started reviewing on behalf of lorenzo132 July 18, 2026 23:01 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

		if self.bot.args:
		msg = UnseenFormatter().format(msg, **self.bot.args)

Uh oh!

Uh oh!

Conversation

lorenzo132 commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

sebkuip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenDaDev commented Jun 15, 2026

Uh oh!

martinbndr left a comment

Choose a reason for hiding this comment

Uh oh!

StephenDaDev left a comment

Choose a reason for hiding this comment

Uh oh!

sebkuip left a comment

Choose a reason for hiding this comment

Uh oh!

sebkuip Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebkuip Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

sebkuip Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

sebkuip Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sebkuip Jul 13, 2026 •

edited

Loading

sebkuip Jul 13, 2026 •

edited

Loading