port test_finalizer#55
Open
bavulapati wants to merge 1 commit into
Open
Conversation
Member
|
@bavulapati I suggest keeping stacked PRs in draft until their parent PRs merge 👍 |
Contributor
Author
|
depends on #53 |
bavulapati
marked this pull request as ready for review
June 12, 2026 15:17
Contributor
Author
|
@legendecas PTAL |
Member
|
This seems blocked on a resolution on #54. |
bavulapati
force-pushed
the
feat/port-test-finalizer
branch
2 times, most recently
from
June 26, 2026 15:59
203a389 to
0f5dd42
Compare
bavulapati
force-pushed
the
feat/port-test-finalizer
branch
from
July 14, 2026 06:47
0f5dd42 to
9f5ef68
Compare
bavulapati
force-pushed
the
feat/port-test-finalizer
branch
from
July 14, 2026 08:04
9f5ef68 to
d2ecbf6
Compare
legendecas
reviewed
Jul 17, 2026
legendecas
reviewed
Jul 17, 2026
Comment on lines
+10
to
+11
| // The original asserts the finalizer runs in the same tick as GC; the harness | ||
| // only exposes async gcUntil, so we settle for observing that it fires. |
Member
There was a problem hiding this comment.
This comment seems superfluous. GC is never guaranteed to be interleaving with any JS code.
gcUtil is the right choice.
Suggested change
| // The original asserts the finalizer runs in the same tick as GC; the harness | |
| // only exposes async gcUntil, so we settle for observing that it fires. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.