Skip to content

zlib: accept ArrayBuffer dictionary in Zstd#64599

Open
islandryu wants to merge 3 commits into
nodejs:mainfrom
islandryu:zstd-arraybuffer-dictionary
Open

zlib: accept ArrayBuffer dictionary in Zstd#64599
islandryu wants to merge 3 commits into
nodejs:mainfrom
islandryu:zstd-arraybuffer-dictionary

Conversation

@islandryu

Copy link
Copy Markdown
Member

Fixes: #64598

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Jul 19, 2026
Fixes: nodejs#64598
Signed-off-by: islandryu <shimaryuhei@gmail.com>
@islandryu
islandryu force-pushed the zstd-arraybuffer-dictionary branch from d2fcfac to 61b8668 Compare July 19, 2026 14:25
Comment thread lib/zlib.js Outdated
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (4f844f4) to head (db7a201).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/zlib.js 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64599      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.01%     
==========================================
  Files         741      741              
  Lines      241976   241983       +7     
  Branches    45543    45551       +8     
==========================================
+ Hits       218116   218158      +42     
+ Misses      15379    15345      -34     
+ Partials     8481     8480       -1     
Files with missing lines Coverage Δ
lib/zlib.js 98.07% <72.72%> (-0.26%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu and others added 2 commits July 20, 2026 01:12
Co-authored-by: James M Snell <jasnell@gmail.com>
Signed-off-by: islandryu <shimaryuhei@gmail.com>
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@islandryu islandryu added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zstd silently ignores an ArrayBuffer passed as the dictionary option

4 participants