Skip to content

Rename double-remove TraceState tests and exercise a non-first entry - #8672

Draft
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:test/trace-state-remove-same-key-tests
Draft

Rename double-remove TraceState tests and exercise a non-first entry#8672
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:test/trace-state-remove-same-key-tests

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Description

Testing done

  • ./gradlew :api:all:test --tests "io.opentelemetry.api.trace.TraceStateTest" — 41 tests passed, 0 skipped. The three renamed methods show up in the test report, so the rename did not drop them.
  • ./gradlew :api:all:check — passed (test, spotless, ErrorProne/NullAway, jApiCmp).
  • jApiCmp produced no docs/apidiffs/current_vs_latest/ update.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 30, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: thswlsqls / name: Eunbin Son (a75c7ab)

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-07-31 13:26 UTC

Move out of draft to request review.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.45%. Comparing base (a0f8f92) to head (a75c7ab).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8672   +/-   ##
=========================================
  Coverage     91.45%   91.45%           
  Complexity    10462    10462           
=========================================
  Files          1021     1021           
  Lines         27680    27680           
  Branches       3244     3244           
=========================================
  Hits          25316    25316           
  Misses         1620     1620           
  Partials        744      744           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Follow-up to review comments on open-telemetry#8613, which were submitted after that PR
had already been merged.

Rename removeTwice, removeTwice_KeepsRemainingEntry and
removeTwice_KeepsRemainingEntries to removeSameKeyTwice*, since all three
remove the same key and the previous names did not say so.

removeSameKeyTwice_KeepsRemainingEntries now removes SECOND_KEY rather than
FIRST_KEY. ArrayBasedTraceStateBuilder.remove scans entries from the front,
so removing the first key always matches on the first iteration; removing a
middle key covers a later slot for the first time.

Test-only: no production code, public API or asserted behavior changes.
@thswlsqls
thswlsqls force-pushed the test/trace-state-remove-same-key-tests branch from 887981f to a75c7ab Compare July 30, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant