Deprecate OpenCensus shim public API - #8674
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
============================================
+ Coverage 91.47% 91.48% +0.01%
- Complexity 10465 10467 +2
============================================
Files 1021 1021
Lines 27694 27694
Branches 3247 3247
============================================
+ Hits 25333 25337 +4
+ Misses 1617 1615 -2
+ Partials 744 742 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The Windows Java 17 job failed during Gradle configuration because Maven Central returned HTTP 429 while resolving Kotlin 2.3.21, before project compilation started. All other OS/JDK builds, both GraalVM builds, CodeQL, API checks, coverage, links, and EasyCLA passed. I do not have permission to rerun the upstream workflow; could a maintainer rerun the failed jobs when convenient? |
Pull request dashboard statusWaiting on reviewers · refreshed 2026-07-31 22:27 UTC Review the latest changes. Status above doesn't look right?
|
jack-berg
left a comment
There was a problem hiding this comment.
Couple of small comments. Thanks!
| * <p>To use, register with {@link SdkMeterProviderBuilder#registerMetricProducer(MetricProducer)}. | ||
| * | ||
| * @deprecated OpenCensus compatibility is deprecated in the OpenTelemetry specification. This shim | ||
| * is deprecated accordingly. Migrate OpenCensus instrumentation to the OpenTelemetry APIs. |
There was a problem hiding this comment.
For the deprecation messages, can you follow the pattern used in the deprecated ZipkinExporter? I.e. link to the spec PR where opencensus was deprecated and indicate that we stop publishing the artifact after June 2027. Use this updated message consistently in all places.
There was a problem hiding this comment.
Addressed in dc333b8. All six deprecation notices now follow the linked specification pattern, reference open-telemetry/opentelemetry-specification#5138, and state that the artifact will no longer be published after June 2027. The targeted shim check and Javadoc task pass locally.
|
/dashboard route:reviewers |
|
@LarryHu0217 routed this pull request to reviewers. |
Summary
This does not change runtime behavior or define the post-deprecation maintenance policy discussed in the issue.
Fixes #8673
Testing
./gradlew :opencensus-shim:spotlessApply :opencensus-shim:check./gradlew :opencensus-shim:build