chore(ExpandableSection): Include OUIAProps for ExpandableSection#12570
chore(ExpandableSection): Include OUIAProps for ExpandableSection#12570mshriver wants to merge 2 commits into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughExpandableSection now accepts OUIA properties, defaults ChangesExpandableSection OUIA support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bd5b2e2 to
2b4c449
Compare
rebeccaalpert
left a comment
There was a problem hiding this comment.
OUIA stuff looks good, but tests are failing.
|
The failing tests in CI are snapshot tests for the |
2b4c449 to
e243b52
Compare
|
/retest |
|
I'm unable to replicate the failures in CI in my local environment, and they appear completely unrelated. |
Add OUIA attribute support to ExpandableSection for better test automation. Co-authored-by: Cursor <cursoragent@cursor.com>
e243b52 to
ff5bdfb
Compare
|
I'm pushing snapshot updates from my local - hopefully that'll get you past. |
|
Seems good now - MultipleFileUpload uses ExpandableSection under the hood, so test was failing. Will approve if CI passes. |
|
One of my colleague @mcoker's favorite incantations is |
Add OUIA attribute support to ExpandableSection for better test automation.
What:
Closes #12569
Snapshot tests commit
#12573
https://github.com/patternfly/patternfly-react/pull/12574/changes
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Documentation
Tests