fix: log watched file changes at debug level - #2554
Open
ousamabenyounes wants to merge 2 commits into
Open
Conversation
dunglas
reviewed
Jul 26, 2026
ousamabenyounes
force-pushed
the
fix-1443-watch-debug-path
branch
from
July 26, 2026 09:26
2dd6110 to
07c74a4
Compare
Contributor
Author
|
Thanks for the review. Addressed the feedback in 07c74a4 by removing the extra log-message/attribute constants and keeping the debug log labels inline with the surrounding style. Validation: local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443.
Changes
Test verification (RED -> GREEN)
RED on
origin/mainplus the new regression test before the implementation:GREEN after the fix:
Command used for GREEN:
go test ./internal/watcher -count=1in Docker with the watcher C library installed.