fix: removes opcache_hook again - #2564
Open
AlliBalliBaba wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
As a sidenote: this makes opcache_resets from many invalidations potentially again unsafe, but as @henderkes mentioned, it's probably better to get a fix in php-src on some of these races |
henderkes
approved these changes
Jul 27, 2026
Contributor
|
It's really unfortunate that we can't kill wedged threads that stall. Hoping for better Linux, Windows and macOS syscalls for that at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the opcache invalidate hook again. Might fix #2553.
A hard restart everytime the opcache resets due to memory overflow sounds like a good idea at first, but if a framework relies on a lot of opcache invalidation, restarts might become recursive.
Probably wasn't a good idea to hook into restarts like this in the first place as it's not really possible to test the behavior.