stream: remove php_stream_fopen_with_path() function#22793
Merged
Girgias merged 1 commit intoJul 19, 2026
Merged
Conversation
It is unused as shown by the following Sourcegraph searches: - https://sourcegraph.com/search?q=context:global+_php_stream_fopen_with_path+-f:plain_wrapper.c+-:php_streams.h&patternType=keyword&sm=0 - https://sourcegraph.com/search?q=context:global+php_stream_fopen_with_path+-f:plain_wrapper.c+-:php_streams.h&patternType=keyword&sm=0
Girgias
deleted the
2026-07-make-private-fn-only-used-by-plain-stream-wrapper
branch
July 19, 2026 14:17
Member
|
You should update UPGRADING.INTERNALS as it's an exported function so possible impact on private extensions (not likely but every exported function removal should be noted there anyway). |
Member
Author
|
As yes, will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is unused as shown by the following Sourcegraph searches:
This function is also somewhat problematic as it can truncate paths.