streams: drop leading _ for most stream functions#22889
Open
Girgias wants to merge 3 commits into
Open
Conversation
The only macro versions being preserved are those passing STREAMS_DC in debug builds.
By dropping the unused flags parameter of the _-prefixed version
Girgias
force-pushed
the
2026-07-streams-fn-useless-macro-wrapper
branch
from
July 25, 2026 21:41
3bb1e5a to
2ef75b1
Compare
By turning the _-prefixed version into a static extended version
Girgias
force-pushed
the
2026-07-streams-fn-useless-macro-wrapper
branch
from
July 26, 2026 11:42
2ef75b1 to
90a48ad
Compare
Girgias
marked this pull request as ready for review
July 26, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only macro versions being preserved are those passing STREAMS_DC in debug builds.
Symbols prefixed with
_are actually reserved by C and thus should not be used in general.This also makes determining usage of those functions really confusing, as it has no benefit, renaming the functions is fine.