Limit the demo box to branches with an approved revision - #446
Open
ECYaz wants to merge 1 commit into
Open
Conversation
The manage page offered a demo URL field and install button for every branch open for uploads, so a style approved only for 3.3 still showed the 3.2 install box. Build the demo box and the details page demo menu from the branches that actually have an approved revision, the same source the download box uses, and preserve stored URLs for branches that are not open for editing when the form is saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377
The manage page built the demo URL box from every branch open for uploads, so a style approved only for 3.3 still offered the 3.2 field and install button. The demo box and the details page demo menu are now built from the branches that actually have an approved revision, the same source the download box uses. Stored URLs for branches that are not shown survive a save, so a pulled revision hides its demo without losing the URL if it is approved again.