Extend the BBCode help field to match phpBB 3.3.5 - #449
Merged
Conversation
phpBB 3.3.5 extended a BBCode's help from a single line to a text column with a textarea (PHPBB3-16804), but the database's submission form kept the old shape: a single line input backed by a varchar(255). Help text longer than 255 characters made the insert fail and showed an empty "User Error" page with the revision not created. Change the column to a text column and the field to a textarea like the core form, rename the label now that the help is no longer one line, and render stored line breaks on the contribution pages. Also wires up the existing but unused REVISION_HELP_LINE_EXPLAIN language string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
The column is now a text column and the field a textarea like the core form, the label is renamed since the help is no longer one line, and stored line breaks render on the contribution pages.