Skip to content

callback args hardening.#3902

Open
T4rk1n wants to merge 5 commits into
devfrom
fix/callback-args-hardening
Open

callback args hardening.#3902
T4rk1n wants to merge 5 commits into
devfrom
fix/callback-args-hardening

Conversation

@T4rk1n

@T4rk1n T4rk1n commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Fix background callbacks trusting the client-supplied job/oldJob/cancelJob and cacheKey query parameters verbatim, which let an unauthenticated client terminate an arbitrary process (with DiskcacheManager, by sending its PID) or read and delete arbitrary result-cache entries. The cacheKey/job handles are now HMAC-signed by the server and bound to a per-page-load token, so forged or replayed values are rejected. Handles stay opaque to the renderer, so no app or callback code changes are required.

@sonarqubecloud

Copy link
Copy Markdown

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but I think @KoolADE85 should give it look before you merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants