Skip to content

[PULP-2012] Cache Simple API responses#1271

Merged
jobselko merged 1 commit into
pulp:mainfrom
jobselko:1254
Jul 21, 2026
Merged

[PULP-2012] Cache Simple API responses#1271
jobselko merged 1 commit into
pulp:mainfrom
jobselko:1254

Conversation

@jobselko

Copy link
Copy Markdown
Member

closes #1254

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@jobselko jobselko self-assigned this Jul 14, 2026
@jobselko
jobselko marked this pull request as ready for review July 14, 2026 15:37
Comment thread pulp_python/tests/functional/api/test_simple_cache.py
Comment thread pulp_python/app/cache.py Outdated
@github-actions github-actions Bot added multi-commit Add to bypass single commit lint check no-changelog no-issue labels Jul 20, 2026
@github-actions github-actions Bot removed multi-commit Add to bypass single commit lint check no-issue no-changelog labels Jul 20, 2026
Comment thread pulp_python/app/pypi/views.py Outdated
Comment thread pulp_python/app/pypi/views.py Outdated

@gerrod3 gerrod3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes, then LTGM

Comment thread pulp_python/app/cache.py Outdated
@extend_schema(summary="Get index simple page")
@method_decorator(cache_control(max_age=600, public=True))
@method_decorator(condition(etag_func=_etag_func))
@PythonApiCache(base_key=find_base_path_cached)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this is really nice!

closes pulp#1254
Assisted By: Claude Opus 4.6

@gerrod3 gerrod3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, good work!

@jobselko
jobselko merged commit 7a3f963 into pulp:main Jul 21, 2026
14 checks passed
@jobselko
jobselko deleted the 1254 branch July 21, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple API responses should be cached server-side and served with HTTP cache headers

2 participants