-
-
Notifications
You must be signed in to change notification settings - Fork 35k
gh-118150: difflib: expose autojunk flag from SequenceMatcher to public methods and functions #153959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
faithlesstomas
wants to merge
9
commits into
python:main
Choose a base branch
from
faithlesstomas:gh-118150-expose-autojunk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−17
Open
gh-118150: difflib: expose autojunk flag from SequenceMatcher to public methods and functions #153959
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
367dc55
difflib: expose autojunk flag from SequenceMatcher to public methods/…
faithlesstomas 9a822c4
difflib: update news for gh118150
faithlesstomas 5e2f622
difflib: fix typyos in docstrings
faithlesstomas 7d86473
gh-118150: difflib - fix NEWS issue with ref. not found
faithlesstomas b5213c9
gh-118150: difflib - fix NEWS doc for ReST
faithlesstomas 7d7a35b
gh-118150: difflib - remove template notes from NEWS
faithlesstomas bd98298
gh-118150: CI fix for check-docs
faithlesstomas af14a4f
gh-118150: how to reference a class in NEWS file?
faithlesstomas e3d69d8
Merge branch 'main' into gh-118150-expose-autojunk
faithlesstomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
Misc/NEWS.d/next/Library/2026-07-18-16-43-02.gh-issue-118150.x0mV8P.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Expose automated junk heruistic flag to the public in difflib. | ||
|
|
||
| .. section: Library | ||
| This change exposes the *autojunk* kwarg — used for turning on/off | ||
| the automated junk heuristic in the :class:`difflib.SequenceMatcher` | ||
| (which defaults to ``True``, meaning this heuristic was always performed | ||
| in :mod:`difflib`) — to the public methods and functions of | ||
| the :mod:`difflib`, so that users can change the behavior of this option. | ||
| See the :class:`difflib.SequenceMatcher` documentation for details. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faithlesstomas you should review this file, it seems to have been very badly AI-generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lenormju I wouldn't have thought that my bad English could be considered to be AI generated :) Do you have any specific suggestion what should be improved in this description?
BTW, nothing in this PR was AI generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faithlesstomas The commit was titled
difflib - fix NEWS issue with ref. not foundwhich I found strange that a human would commit "ref. not found". Also the NEWS file contain these comments :Which look like a template you did not erase.
I was not basing myself on the English, instead on all the rest. But if it wasn't, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lenormju Sorry, that was my mistake - I thought this comment is to be left there. Also I didn't know how properly reference a class in ReST... But besides that, does this PR look good now?