Improve colorsys coverage#153982
Merged
Merged
Conversation
tomasr8
reviewed
Jul 18, 2026
tomasr8
added
needs backport to 3.13
| ((0.0, 0.0, 1.0), (0.0, -1.0, 0.5)) | ||
| ] | ||
|
|
||
| for (rgb, yiq) in values: |
Member
There was a problem hiding this comment.
Please use unittest.subTest(the support decorator instead is fine, too) here, see the documentation.
Contributor
Author
There was a problem hiding this comment.
Done, please have a look
tomasr8
approved these changes
Jul 19, 2026
|
Thanks @MonadChains for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-154076 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154077 is a backport of this pull request to the 3.14 branch. |
|
GH-154078 is a backport of this pull request to the 3.13 branch. |
Member
|
Thank you @MonadChains ! |
tomasr8
pushed a commit
that referenced
this pull request
Jul 19, 2026
tomasr8
pushed a commit
that referenced
this pull request
Jul 19, 2026
tomasr8
pushed a commit
that referenced
this pull request
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes improve the test coverage and robustness of the
colorsysmodule.They add an extra test to ensure that HSV to RGB remains constant in the case of a 360° phase shift of the Hue.
Additionally, it tests the clamping fallback in the case of YIQ to RGB conversion.