Skip to content

Add vfspath TypeError test#153987

Merged
tomasr8 merged 1 commit into
python:mainfrom
AjobK:add-invalid-vfspath-test
Jul 18, 2026
Merged

Add vfspath TypeError test#153987
tomasr8 merged 1 commit into
python:mainfrom
AjobK:add-invalid-vfspath-test

Conversation

@AjobK

@AjobK AjobK commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ensures that an object of an invalid type, such as vfspath(None), trigger a TypeError with an appropriate message

@AjobK
AjobK requested a review from barneygale as a code owner July 18, 2026 14:50
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 18, 2026
@python-cla-bot

python-cla-bot Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@AjobK
AjobK force-pushed the add-invalid-vfspath-test branch from 04c5498 to 554f65c Compare July 18, 2026 15:31
@tomasr8

tomasr8 commented Jul 18, 2026

Copy link
Copy Markdown
Member

@AjobK For future reference, try to avoid force pushing :)

@AjobK AjobK changed the title Add vfsopen TypeError test Add vfstype TypeError test Jul 18, 2026
@AjobK AjobK changed the title Add vfstype TypeError test Add vfspath TypeError test Jul 18, 2026
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 18, 2026
@tomasr8
tomasr8 enabled auto-merge (squash) July 18, 2026 15:58
@tomasr8 tomasr8 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 18, 2026
@tomasr8
tomasr8 merged commit 5763bfd into python:main Jul 18, 2026
58 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Thanks @AjobK for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-154010 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Sorry, @AjobK and @tomasr8, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5763bfdd1b582ef30cf3e6dd88754991973c77ce 3.13

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-154011 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
@tomasr8 tomasr8 removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2026
tomasr8 added a commit that referenced this pull request Jul 19, 2026
@miss-islington @AjobK @tomasr8
[3.15] Add vfspath TypeError test (GH-153987) (#154010)
becc0f6 
Add vfspath TypeError test (GH-153987)

typeerror with message test
(cherry picked from commit 5763bfd)

Co-authored-by: Ajob Kustra <ajobkustra.p@gmail.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

Assignees

@tomasr8 tomasr8

Labels

skip issue skip news sprint tests Tests in the Lib/test dir

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AjobK @tomasr8