Skip to content

gh-154001: Avoid division by zero in binomialvariate#154004

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
lkk7:fix-binomialvariate-div-by-zero
Jul 19, 2026
Merged

gh-154001: Avoid division by zero in binomialvariate#154004
serhiy-storchaka merged 4 commits into
python:mainfrom
lkk7:fix-binomialvariate-div-by-zero

Conversation

@lkk7

@lkk7 lkk7 commented Jul 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

random.binomialvariate() can raise ZeroDivisionError when random() returns 0.0 in one of the paths.

My initial simplest proposal of the fix is to reject zero, matching the retry behavior used in the other path.

Added regression tests.

Fixes #154001

@lkk7
lkk7 requested a review from rhettinger as a code owner July 18, 2026 15:21
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
Closed
ByteFlowing1337
ByteFlowing1337 reviewed Jul 18, 2026
View reviewed changes
Comment thread Lib/random.py Outdated
Comment thread Misc/NEWS.d/next/Library/2026-07-18-17-09-49.gh-issue-154001.3brrUv.rst Outdated
vstinner
vstinner approved these changes Jul 18, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @serhiy-storchaka @rhettinger

@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 18, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jul 19, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka
serhiy-storchaka merged commit 1f13740 into python:main Jul 19, 2026
51 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thanks @lkk7 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154050 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154051 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154052 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2026
serhiy-storchaka pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @lkk7
[3.13] gh-154001: Avoid division by zero in binomialvariate (GH-154004)…
b51a036 
… (GH-154052)

(cherry picked from commit 1f13740)

Co-authored-by: Łukasz <lukaszlapinski7@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @lkk7
[3.14] gh-154001: Avoid division by zero in binomialvariate (GH-154004)…
64bccca 
… (GH-154051)

(cherry picked from commit 1f13740)

Co-authored-by: Łukasz <lukaszlapinski7@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Jul 19, 2026
@miss-islington @lkk7
[3.15] gh-154001: Avoid division by zero in binomialvariate (GH-154004)…
15335ae 
… (GH-154050)

(cherry picked from commit 1f13740)

Co-authored-by: Łukasz <lukaszlapinski7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@ByteFlowing1337 ByteFlowing1337 Awaiting requested review from ByteFlowing1337

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

random.binomialvariate() can raise ZeroDivisionError when random() returns 0.0

4 participants

@lkk7 @vstinner @serhiy-storchaka @ByteFlowing1337