gh-130655: Add tests for dgettext, dngettext, dpgettext, dnpgettext#154006
Open
magic-peach wants to merge 1 commit into
Open
gh-130655: Add tests for dgettext, dngettext, dpgettext, dnpgettext#154006magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
…text Add focused test coverage for the domain-specific gettext functions that were previously only tested indirectly. This extends the work started in pythongh-134594 to cover all four domain-specific functions. Each function is tested with a for loop and subTests covering: - Existing translations - Missing translations (fallback to original message) - Nonexistent domains (fallback to original message) - Context-based translations (dpgettext, dnpgettext) - Plural forms (dngettext, dnpgettext) - Wrong/missing contexts Updated the TODO comment to reference the issue and additional functions that now have coverage.
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Usually, it is common to first ask on the original PR whether the author intends to pursue their work before creating a similar PR. Please discuss this in #134594. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dgettext,dngettext,dpgettext, anddnpgettextMotivation
This addresses the TODO at
Lib/test/test_gettext.py:13-15and extends the work in gh-134594 to cover all four domain-specific gettext functions.Design
Each function is tested with a single test method using a for loop and
subTestfor clear failure reporting, following reviewer feedback:All test classes inherit from
GettextBaseTestto reuse existing.motest fixtures. Tests follow reviewer feedback:super().setUp()instead of explicit parent callAll 25 test assertions verified passing against the current
main.gettext#130655