Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Lib/test/test_free_threading/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,20 @@ def reset_worker():
decoder.reset()

run_concurrently([decode_worker] * 2 + [reset_worker] * 2)


class TextIOWrapperTest(TestCase):
def test_buffer_detach_race(self):
make = lambda: io.TextIOWrapper(io.BytesIO())
slot = [make()]

def reader():
for _ in range(1000):
slot[0].buffer

def detacher():
for _ in range(1000):
slot[0] = make()
slot[0].detach()

run_concurrently([reader, detacher])
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed data-race when calling :meth:`io.TextIOBase.detach` in
:term:`free-threaded build`.
2 changes: 1 addition & 1 deletion Modules/_io/textio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1639,7 +1639,7 @@ _io_TextIOWrapper_detach_impl(textio *self)
if (buffer == NULL) {
return NULL;
}
self->buffer = NULL;
FT_ATOMIC_STORE_PTR_RELAXED(self->buffer, NULL);
self->detached = 1;
return buffer;
}
Expand Down
Loading