Skip to content

gh-153852: Assert thread list non-empty only after stopping the world (TSAN-0034) #154716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vamsi-klu wants to merge 1 commit into from
+2 −1
Closed

gh-153852: Assert thread list non-empty only after stopping the world (TSAN-0034) #154716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-07-26-12-00-00.gh-issue-153852.a1b2c3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a free-threading race in finalization by asserting the thread list is non-empty only after stopping the world.
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3827,8 +3827,8 @@ handle_thread_shutdown_exception(PyThreadState *tstate)
assert(tstate != NULL);
assert(_PyErr_Occurred(tstate));
PyInterpreterState *interp = tstate->interp;
assert(interp->threads.head != NULL);
_PyEval_StopTheWorld(interp);
assert(interp->threads.head != NULL); /* safe: world is stopped */

// We don't have to worry about locking this because the
// world is stopped.
Expand Down
Loading