Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
If available on the platform, use native :c:type:`_Float16` in
:c:func:`PyFloat_Pack2` and :c:func:`PyFloat_Unpack2` functions. Patch by
Sergey B Kirpichev.
79 changes: 79 additions & 0 deletions Objects/floatobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -1894,6 +1894,47 @@ _PyFloat_DebugMallocStats(FILE *out)
int
PyFloat_Pack2(double x, char *data, int le)
{
#if HAVE_FLOAT16
unsigned char *p = (unsigned char *)data;
_Float16 y = (_Float16)x;
int i, incr = 1;

if (isinf(y) && !isinf(x)) {
PyErr_SetString(PyExc_OverflowError,
"float too large to pack with e format");
return -1;
}

/* correct y if x was a sNaN, transformed to qNaN by conversion */
if (isnan(x)) {
uint64_t v;

memcpy(&v, &x, 8);
if ((v & (1ULL << 51)) == 0) {
uint16_t u16;
memcpy(&u16, &y, 2);
/* if have payload, make sNaN */
if (u16 & 0x1ff) {
u16 &= ~(1 << 9);
}
memcpy(&y, &u16, 2);
}
}

unsigned char s[sizeof(_Float16)];
memcpy(s, &y, sizeof(_Float16));

if ((_PY_FLOAT_LITTLE_ENDIAN && !le) || (_PY_FLOAT_BIG_ENDIAN && le)) {
p += 1;
incr = -1;
}

for (i = 0; i < 2; i++) {
*p = s[i];
p += incr;
}
return 0;
#else
unsigned char *p = (unsigned char *)data;
unsigned char sign;
int e;
Expand Down Expand Up @@ -1997,6 +2038,7 @@ PyFloat_Pack2(double x, char *data, int le)
PyErr_SetString(PyExc_OverflowError,
"float too large to pack with e format");
return -1;
#endif /* HAVE_FLOAT16 */
}

int
Expand Down Expand Up @@ -2089,6 +2131,42 @@ PyFloat_Pack8(double x, char *data, int le)
double
PyFloat_Unpack2(const char *data, int le)
{
#if HAVE_FLOAT16
unsigned char *p = (unsigned char *)data;
_Float16 x;

if ((_PY_FLOAT_LITTLE_ENDIAN && !le) || (_PY_FLOAT_BIG_ENDIAN && le)) {
char buf[2];
char *d = &buf[1];
int i;

for (i = 0; i < 2; i++) {
*d-- = *p++;
}
memcpy(&x, buf, 2);
}
else {
memcpy(&x, p, 2);
}

/* return sNaN double if x was sNaN float */
if (isnan(x)) {
uint16_t v;

memcpy(&v, &x, 2);
if ((v & (1 << 9)) == 0) {
double y = x; /* will make qNaN double */
uint64_t u64;

memcpy(&u64, &y, 8);
u64 &= ~(1ULL << 51); /* make sNaN */
memcpy(&y, &u64, 8);
return y;
}
}

return x;
#else
unsigned char *p = (unsigned char *)data;
unsigned char sign;
int e;
Expand Down Expand Up @@ -2140,6 +2218,7 @@ PyFloat_Unpack2(const char *data, int le)
x = -x;

return x;
#endif /* HAVE_FLOAT16 */
}

double
Expand Down
58 changes: 58 additions & 0 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -4457,6 +4457,24 @@ if test "$ac_cv_ffi_complex_double_supported" = "yes"; then
[Defined if _Complex C type can be used with libffi.])
fi

# Check for native half-float type.
AC_CACHE_CHECK([for _Float16 support], [ac_cv_float16_supported],
WITH_SAVE_ENV([
CFLAGS="$CFLAGS -mf16c"
AC_RUN_IFELSE([AC_LANG_SOURCE([[
int main(void)
{
_Float16 val = 1.0f16;
return 0;
}
]])], [ac_cv_float16_supported=yes],
[ac_cv_float16_supported=no],
[ac_cv_float16_supported=no])]))
AS_VAR_IF([ac_cv_float16_supported], [yes],
[AC_DEFINE([HAVE_FLOAT16], [1],
[Defined if _Float16 C type is supported])
BASECFLAGS="$BASECFLAGS -mf16c"])

dnl Check for libmpdec >= 2.5.0
PKG_CHECK_MODULES([LIBMPDEC], [libmpdec >= 2.5.0], [have_mpdec=yes], [
WITH_SAVE_ENV([
Expand Down
3 changes: 3 additions & 0 deletions pyconfig.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,9 @@
/* Define if you have the 'ffi_prep_closure_loc' function. */
#undef HAVE_FFI_PREP_CLOSURE_LOC

/* Defined if _Float16 C type is supported */
#undef HAVE_FLOAT16

/* Define to 1 if you have the 'flock' function. */
#undef HAVE_FLOCK

Expand Down
Loading